Page MenuHomePhabricator
Create Task
Maniphest T175867

[wmf.18 - regression] oo-ui-iconElement-icon oo-ui-icon-userAvatar and others are missing in Echo notifications
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Etonkovidova
Sep 13 2017, 9:11 PM
Tags
Referenced Files
F9519618: Screen Shot 2017-09-13 at 9.16.48 PM.png
Sep 14 2017, 4:17 AM
F9511457: Screen Shot 2017-09-13 at 1.54.56 PM.png
Sep 13 2017, 9:11 PM
F9512052: Screen Shot 2017-09-13 at 2.09.10 PM.png
Sep 13 2017, 9:11 PM
Subscribers
Aklapper
Etonkovidova
gerritbot

Description

Compare:
testwiki wmf.18 - only the dotdotdot is present:

Screen Shot 2017-09-13 at 2.09.10 PM.png (608×1 px, 131 KB)

frwiki - the same user's notifications - the icons for a user and a speech bubble are in place.

Screen Shot 2017-09-13 at 1.54.56 PM.png (522×1 px, 128 KB)

Details

SubjectRepoBranchLines +/-
Use "formatversion: 2" in notification fetchingmediawiki/extensions/Echowmf/1.30.0-wmf.18+1 -0
Use "formatversion: 2" in notification fetchingmediawiki/extensions/Echomaster+1 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Sep 13 2017, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2017, 9:11 PM
gerritbot subscribed.Sep 13 2017, 10:19 PM

Change 377905 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Echo@master] Use "formatversion: 2" in notification fetching

https://gerrit.wikimedia.org/r/377905

gerritbot added a project: Patch-For-Review.Sep 13 2017, 10:19 PM
Mooeypoo claimed this task.Sep 13 2017, 10:19 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Sep 13 2017, 10:23 PM

Change 377910 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Echo@wmf/1.30.0-wmf.18] Use "formatversion: 2" in notification fetching

https://gerrit.wikimedia.org/r/377910

gerritbot added a comment.Sep 13 2017, 10:29 PM

Change 377905 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use "formatversion: 2" in notification fetching

https://gerrit.wikimedia.org/r/377905

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 13 2017, 11:00 PM
gerritbot added a comment.Sep 13 2017, 11:12 PM

Change 377910 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.30.0-wmf.18] Use "formatversion: 2" in notification fetching

https://gerrit.wikimedia.org/r/377910

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 14 2017, 12:00 AM
Etonkovidova added a comment.Sep 14 2017, 4:17 AM

Checked in mediawiki and cawiki (wmf.18) - all icons are back in place

Screen Shot 2017-09-13 at 9.16.48 PM.png (695×1 px, 218 KB)

Etonkovidova closed this task as Resolved.Sep 14 2017, 4:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits