RCTopSection toplinks has tabindex=0 applied, the ButtonElement and the ButtonElement-button which catches the keyboard focus one time too much.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix tabindex applied twice on RC top section | mediawiki/core | master | +2 -1 |
Event Timeline
Comment Actions
Change 384518 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Fix tabindex applied twice on RC top section
Comment Actions
I merged the hack, but @Volker_E isn't this a bug in OOUI? We're replacing a php-ooui button with javascript ooui button, why is the tab index applied twice? Could that be the reason? Beyond fixing the individual problem, let's see if there's an issue with ooui itself here?
Comment Actions
Change 384518 merged by jenkins-bot:
[mediawiki/core@master] Fix tabindex applied twice on RC top section
Comment Actions
Checked in betalabs. Previously, there were two tabindex="0"
<div class="mw-rcfilters-ui-cell mw-rcfilters-ui-rcTopSectionWidget-topLinks-table"><div class="mw-recentchanges-toplinks mw-collapsible mw-collapsed"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-indicatorElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" aria-disabled="false" tabindex="0"><a class="oo-ui-buttonElement-button" role="button" tabindex="0" [...]
Now, tabindex is left only for oo-ui-buttonElement-button"
<div class="mw-rcfilters-ui-cell mw-rcfilters-ui-rcTopSectionWidget-topLinks-table"><div class="mw-recentchanges-toplinks mw-recentchanges-toplinks-collapsed mw-collapsible mw-collapsed"><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-frameless oo-ui-indicatorElement oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-buttonWidget" aria-disabled="false"><a class="oo-ui-buttonElement-button" role="button" tabindex="0"
Navigating the links via keyboard does not require now unnecessary click on 'Other review tools' link.