We have been informally running our scripts through ShellCheck, but that should be enforced by CI.
- Mentioned In
- T175899: ErfgoedBot missing_commonscat_links crashes with 'NoneType' object is not iterable
- Mentioned Here
- rTHER5e5c828a109b: Bump PHP dependencies in composer.json
rTHER2486630dee04: Add Bash linting using bashate
rTHER3ac13b6c7885: Skip SPARQL type in missing_commonscat_links.py
T175899: ErfgoedBot missing_commonscat_links crashes with 'NoneType' object is not iterable
T148494: Add shell scripts CI validations
@hashar How would you recommend we go about running ShellCheck on CI for the heritage repo ? ShellCheck is a Haskell application, so we cannot install it for our usual entry-points (tox, npm test or composer test). Unless shellcheck is already installed globally on Jenkins slaves, in which case we can just use whichever (I’d go for tox) to run it.