Page MenuHomePhabricator

[Bug] wikibase.experts.getStore does not require it's namespace
Closed, ResolvedPublic

Description

Reported at https://www.mediawiki.org/wiki/Topic:Ty4vs2ssccigib5s: "TypeError: Cannot set property 'getStore' of undefined". And indeed, I find that the MediaWiki-ResourceLoader module wikibase.experts.getStore does not properly depend on the required wikibase.experts.__namespace module.

This is a Regression. The issue was accidentally introduced with https://gerrit.wikimedia.org/r/#/c/361498/12/repo/resources/experts/resources.php (T167964: [Task] Inject frontend part of lexeme datatype from WikibaseLexeme extension) in June this year.

Event Timeline

Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald Transcript

Change 378013 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Require missing namespace for wikibase.experts.getStore module

https://gerrit.wikimedia.org/r/378013

thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde updated the task description. (Show Details)
thiemowmde added subscribers: hoo, aude.

Change 378013 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Require missing namespace for wikibase.experts.getStore module

https://gerrit.wikimedia.org/r/378013