Page MenuHomePhabricator

deploy tracking-hack on beta-wiki
Closed, ResolvedPublic

Description

@Addshore
Could you do that for next week and get back when it's done, please?

Here you can Find the information about the banners and campaign tags: T191506

Event Timeline

This just needs https://gerrit.wikimedia.org/r/#/c/377229/3 to be merged and it will be deployed to beta within minutes!

@Tobi_WMDE_SW I can +2 it myself but would appreciate 1 more review, perhaps from you?

I had a look into https://gerrit.wikimedia.org/r/#/c/377229/3 and saw

jenkins-bot | Change has been successfully merged by jenkins-bot | Sep 14 5:18 PM

Does that mean the task is done?

Change 378232 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikimediaEvents@master] Fix second campaign param check in onBeforeInitializeWMDECampaign

https://gerrit.wikimedia.org/r/378232

I had a look into https://gerrit.wikimedia.org/r/#/c/377229/3 and saw

jenkins-bot | Change has been successfully merged by jenkins-bot | Sep 14 5:18 PM

Does that mean the task is done?

I just did a quick test and looks like there was one issue which I have fixed in the patch above.
The final version should be live on beta in the next 30 mins

Change 378232 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Fix second campaign param check in onBeforeInitializeWMDECampaign

https://gerrit.wikimedia.org/r/378232

Awesome - Thanks!

Do you need an information when the test is done to shut down the hack again?

@Stefan_Schneider_WMDE nope, as the code will be on beta for the full time that the code will be in production too (this is the normal process)
It wont be removed from beta until the code is also removed from production.

The code will be dewiki in production next Thursday!

Addshore closed this task as Resolved.Sep 15 2017, 2:34 PM
Addshore claimed this task.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.
Addshore moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-09-05 board.