Page MenuHomePhabricator

Add unit tests to EventBus extension
Closed, ResolvedPublic

Description

The EventBus infrastructure is becoming more and more important as all RESTBase updates are dependent on it and now the JobQueue is being migrated, but the EventBus extension has no unit tests.

It's hard to make tests for the hooks, but we have to at least test common functionality like event serialization.

Event Timeline

Pchelolo created this task.Sep 14 2017, 8:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2017, 8:13 PM

Change 378694 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] [Tests] Added several basic tests to static helpers

https://gerrit.wikimedia.org/r/378694

Change 378694 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] [Tests] Added several basic tests to static helpers

https://gerrit.wikimedia.org/r/378694

Pchelolo closed this task as Resolved.Sep 19 2017, 1:40 PM

Some tests were added by the above patches - coverage is not great yet, but I think we can resolve this now.