| • NHarateh_WMF | |
| Sep 15 2017, 2:38 AM |
| F9545509: 53CA4775-CB0F-4816-BEB5-829EC186CBB9.png | |
| Sep 15 2017, 2:38 AM |
Always
That same event shouldn’t be duplicated
There are 2 cards for the same event
App version: 5.6.0 (1195)
OS versions: 11
Device model: iPhone 7 Plus
Device language: EN
Tag task with Regression
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix duplicate pages in some on-this-day results. | mediawiki/services/restbase | master | +17 -1 |
https://en.wikipedia.org/api/rest_v1/feed/onthisday/events/09/14 has two instances of 'MCI_Inc.' because WorldCom redirects to MCI_Inc. (This event data comes from https://en.wikipedia.org/wiki/September_14#Events.)
To solve this we could look to suppress duplicate titles in an onthisday entry.
Per conversation with @bearND :
Look at https://github.com/wikimedia/restbase/blob/master/v1/onthisday.js#L29 as place to try post title-hydration de-dupe.
Look at https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/RESTBase_services_for_apps#Setting_up_a_local_Parsoid_instance for getting local instance to do hydration for testing.
Change 402155 had a related patch set uploaded (by Mhurd; owner: montehurd):
[mediawiki/services/restbase@master] Fix duplicate pages in some on-this-day results.
@bearND There may be a simpler way to dip into the promisified response to access the pages...
Change 402155 abandoned by Mhurd:
Fix duplicate pages in some on-this-day results.
Reason:
Per Mholloway's reminder, I need to use a PR for this proj.
@Mholloway Here's the PR on github:
https://github.com/wikimedia/mediawiki-services-restbase/pull/1
Is this the right place? Odd that it would be PR 1...
@Mhurd It's https://github.com/wikimedia/restbase.
You can remove the Change-Id in the PRs. That's a Gerrit thing.
@Mholloway @bearND
Ok this should be correct finally :)
https://github.com/wikimedia/restbase/pull/937
Should https://github.com/wikimedia/mediawiki-services-restbase mirror be removed to avoid future confusion?
Mentioned in SAL (#wikimedia-operations) [2018-01-10T12:55:37Z] <mobrovac@tin> Started deploy [restbase/deploy@a2aabfb]: API: add top-by-country, change recommendation route, fix duplicates in onthisday - T181520 T170877 T175974
Mentioned in SAL (#wikimedia-operations) [2018-01-10T13:03:37Z] <mobrovac@tin> Finished deploy [restbase/deploy@a2aabfb]: API: add top-by-country, change recommendation route, fix duplicates in onthisday - T181520 T170877 T175974 (duration: 08m 00s)