CollationFaTest errors in clean MW installation
Closed, ResolvedPublic
Actions

Description

I just installed a brand new version of MediaWiki from git HEAD currently at ecefa8f10821, with no extensions or special configurations. After running composer update I ran the phpunit.php and got 9 errors all pertaining to the CollationFaTest::testGetFirstLetter complaining that "An ICU collation was requested, but the intl extension is not available."

The unit test was added by @Bawolff in May 2017.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+7 -0	Do not run CollationFaTest if 'intl' is not loaded

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T176039 Ensure no errors or failures occur with MediaWiki core tests on a clean installation
		Resolved		Huji	T176040 CollationFaTest errors in clean MW installation

Event Timeline

Huji created this task.Sep 16 2017, 2:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2017, 2:44 PM

Huji triaged this task as Medium priority.Sep 16 2017, 2:46 PM

Huji updated the task description. (Show Details)

Huji added a parent task: T176039: Ensure no errors or failures occur with MediaWiki core tests on a clean installation.

Huji updated the task description. (Show Details)Sep 16 2017, 2:48 PM

The issue was with my environment. sudo apt-get install php-intl solved it.

This is probably nevertheless valid. I think we don't require php-intl for MediaWiki to run, so the test should skip itself when it's not installed. Like this I guess: (copied from XMLTest)

	protected function setUp() {
		parent::setUp();
		if ( !extension_loaded( 'intl' ) ) {
			$this->markTestSkipped( "PHP extension 'intl' is not loaded, skipping." );
		}
	}

Fair. I will work on a patch.

I agree with @matmarex's assesment