Maniphest T176086

Some design changes of Babel extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Iniquity
	Sep 17 2017, 1:02 PM

Tags

Referenced Files

	F9603232: babel test -2.png
	Sep 17 2017, 1:18 PM

	F9602549: babel test -2.png
	Sep 17 2017, 1:02 PM

	F9602550: babel-test.png
	Sep 17 2017, 1:02 PM

Subscribers

Description

Hello, I want to fix some problems with this ext:

Fix /* header and footer */ rules in https://phabricator.wikimedia.org/diffusion/EBAB/browse/master/resources/ext.babel.css (we haven't .mw.babel-box class)
Add text-size: 85% for mw-babel-footer
~~Change .mw-babel-box table size when mw-babel-box included in mw-babel-wrapper to align with another userboxes.~~
Fix toxic color of level-5 box.
Add 'margin' rule for mw-babel-header
Delete monospace font-family for codes (everybody (Commons and Meta) deletes this feature)

Current	Proposed

Details

	Subject	Repo	Branch	Lines +/-
	Small fix: forced text centering of code cell; add one more author	mediawiki/extensions/Babel	master	+3 -1
	Some design fixes and improvements:	mediawiki/extensions/Babel	master	+56 -39

Customize query in gerrit

Event Timeline

Iniquity created this task.Sep 17 2017, 1:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2017, 1:02 PM

Iniquity added a comment.Sep 17 2017, 1:12 PM

This comment was removed by Iniquity.

Iniquity updated the task description. (Show Details)Sep 17 2017, 1:15 PM

Iniquity updated the task description. (Show Details)Sep 17 2017, 1:18 PM

Liuxinyu970226 subscribed.Sep 17 2017, 2:32 PM

Iniquity updated the task description. (Show Details)Sep 17 2017, 3:07 PM

https://gerrit.wikimedia.org/r/#/c/378507/

@Nikerabbit , @Amire80 hi, can you help with it?:)

Have you checked whether these changes align with the WikimediaUI style guides?

In T176086#3620355, @Nikerabbit wrote:

Have you checked whether these changes align with the WikimediaUI style guides?

Hi. No, I havent, I have tried to save original design style.

@Nikerabbit What a part of these changes I need to check? :)

@Nikerabbit fixed :)

Change 378507 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Some design fixes and improvements:

https://gerrit.wikimedia.org/r/378507

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 11 2017, 2:00 PM

Iniquity added a project: Verified.Oct 13 2017, 11:14 AM

Fix for #babel which included in an additional block with text-aling:left
https://gerrit.wikimedia.org/r/#/c/384220/

Iniquity updated the task description. (Show Details)Oct 14 2017, 4:03 PM

Iniquity moved this task from Backlog to Visual design on the MediaWiki-extensions-Babel board.Oct 14 2017, 4:49 PM

Iniquity added a project: Patch-For-Review.Oct 15 2017, 2:22 PM

@thiemowmde Hi:) I think we can megre it

Change 384220 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Small fix: forced text centering of code cell; add one more author

https://gerrit.wikimedia.org/r/384220

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 24 2017, 4:00 PM

Thanks!

Iniquity removed projects: Patch-For-Review, Verified.Oct 24 2017, 4:13 PM

Liuxinyu970226 unsubscribed.Oct 25 2017, 6:27 AM

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 30 2017, 3:01 PM