Page MenuHomePhabricator

Banner close button overlaps search controls on mobile
Open, Needs TriagePublic

Description

  1. View a mobile page when there's an active banner.
  2. Interact with the search bar.

This visually removes the banner, except for its close button.

The searchbar also has its own close button (two actually).

End result:

  • "x" inside the search input field.
  • "X" outside the search input field.
  • Another "(X)" outside the search input field.

Mobile:

Desktop:

1x2x3x
3x (landscape)

Event Timeline

Krinkle created this task.Sep 17 2017, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2017, 6:03 PM

@Krinkle - I've pulled that banner. Will take a look at it.

Jseddon claimed this task.Sep 17 2017, 7:06 PM
Jdlrobson added a subscriber: Jdlrobson.

@Jseddon we use a z-index of 1 for overlays.
It's defined in a LESS variable - @z-indexOverOverlay
So essentially any use of z-index in a banner will cause this problem. Is this common? Can we avoid it or do we need to up those values in the skin?

Pcoombe added a subscriber: Pcoombe.

@Jseddon This appears to be fixed in Community_banner_templatev2. Can this task be resolved?

@Jseddon: Could you answer the last question please?