Page MenuHomePhabricator

Inconsistent positioning of cached data message.
Open, LowestPublic

Description

Some pages put the message about data being cached before the introduction: http://www.mediawiki.org/wiki/Special:UnusedImages

Others put it after the introduction: http://www.mediawiki.org/wiki/Special:UncategorizedCategories

The message should always be in the same position. In my opinion it makes most sense to come after the introduction (so you know what the page is about) and before the data (so the data directly follows the warning).


Version: 1.24rc
Severity: minor

Details

Reference
bz15616
Related Gerrit Patches:

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:22 PM
bzimport set Reference to bz15616.
bzimport added a subscriber: Unknown Object (MLST).
Qgil added a comment.Apr 16 2013, 6:22 AM

... and this is the case still today.

Sumit added a subscriber: Sumit.Dec 23 2014, 7:09 PM

I'm new and would like to work on the bug, could anyone point out that if the flashing of the message is page specific so in what all pages should I look for to make the change?

This is due to a small design fault in the code, there are two provisions to give a "Header". One is got by checking for "<pagename>-summary" message, while the other is manually set.

Any help on how I could fix this ? Would it be wise to change the languages/i18n/en.json and remove entries like "unusedcategoriestext" and move the message from there into "categoriespage-summary" ?
In all the cases when the message name is hardcoded, the <pagename>-summary is empty, so this wouldnt cause any clashes.
Also, the "<pagename>text" hasnt been used anywhere (verified using git grep).

The special pages which have not used the <pagename>-summary message key are:

  • LonelyPages
  • UnusedTemplates
  • DoubleRedirects
  • UnusedImages
  • UnusedCategories
  • BrokenRedirects
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2015, 9:52 AM

Change 237979 had a related patch set uploaded (by TasneemLo):
getPageHeader() -> outputHeader() when possible

https://gerrit.wikimedia.org/r/237979

Qgil removed a subscriber: Qgil.Sep 14 2015, 5:43 AM
TasneemLo set Security to None.Dec 20 2015, 9:12 AM
TasneemLo removed a subscriber: TasneemLo.
Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:32 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 2 2017, 1:32 PM