Page MenuHomePhabricator

[BUG] Cannot switch between Simplified and Traditional Chinese variants using the language switcher
Closed, ResolvedPublic

Description

Steps to reproduce
  1. Open an article available in Chinese as well as at least one other language - Eg. "Barack Obama" in English
  2. Tap on the language switcher icon on the bottom article toolbar and select either the Traditional or Simplified Chinese variant of that article
  3. Once the article loads, tap on the language switcher icon again.
Expected

The user is able switch to the other Chinese variant not selected in step 2.

Actual

The other variant is not shown as an option for selection.
open to view animated gif

Chinese variant bug lang switcher.gif (960×540 px, 3 MB)

Occurring on

Nexus 6.0.1
Wikipedia v2.6.203-alpha-2017-09-15

Details

Event Timeline

cooltey added subscribers: Mholloway, Dbrant, cooltey.

Regarding to this issue, I did some tests and had some ideas:

  1. If an article has a Chinese version, so that article can be changed to different variants.
  1. Noticed that every 中文 Chinese version article has a special tab that allow users to change variants

Here is the idea:

How about we create a method to show these five available variants in the "Other Language" only when a user is reading a Chinese article?
Based on my tests, we can send Accept-Language in Header with the options I mentioned above, and they do translate to the correct variant.

How do you think about this @Dbrant @Mholloway , I am not sure it is the best way to solve this issue..

Hi @cooltey - just wanted to clarify the steps of this bug as I'm trying to understand your proposal:

Within the app, when users choose to view an article in "Other languages" the ZH version of that article to be viewed is presented as split into two options, so a user can choose to view it either in "Traditional Chinese" or "Simplified Chinese" variant in one-step (ie. "ZH" and the variant HANT or HANS in one selection). However, I believe the issue is that once the user is on that Chinese language version of that article, ZH (in any variant) will no longer be shown in the list of other language because it is already technically set to Chinese, much in the same way an EN-wiki article does not include English in the "Other languages" option.

Bearing that in mind, are you suggesting that we change it so that users select 'Chinese' as a language, and add a second step to select the 5 geo-variants? If so this would be quite a change to the existing behavior where the variant type is selected as a single language setting:

Screenshot_20170922-020637.png (1×1 px, 147 KB)

Thanks @RHo

In my opinion, it is not necessary to add a second step to select the 5 geo-variants.

We can dynamically add these 5 geo-variant items into the original "Other Language" list when user selects a "Chinese Language", and the ideal way is to move these 5 geo-variants to the top of the lists.

obama_4.png (1×2 px, 1 MB)

As you can see, we can add these 5 geo-variant items into the top of the "Other Language" list.

hi @cooltey - It seems unexpected for the user that only after selecting Trad/Simp Chinese in the article that these 5 geo-variants included in the 'Other Languages' list. Unless you are saying we should no longer have the selection of the 2 variants Traditional/Simplified across the app, but have users select one of the 5 geo-variants instead?

If so, we would have to change the selection at the app settings level and search language, as well as the "Other languages" list. If this solves the variant issues then I would be supportive. And would this be non-disruptive to existing users who have already set their Wiki app language to Trad/Simp - ie would their language setting automatically get changed to a matching geo-variant?

Thanks @RHo, How about:

  • Solution 1: Detect the "Other Language" to see if we have Trad/Simp Chinese in the list, and then we can dynamically replace/add 5 geo-variants into the list. (Before selecting Trad/Simp Chinese)
  • Solution 2: Keep it simple, remain two Chinese variants in the list, and make sure the Trad/Simp Chinese are added into the list when user is reading a Chinese article. (After selecting Trad/Simp Chinese)

It is also a good way to add 5 geo-variants into the app setting level and search language, but it might affect the exiting users who have already setup the app language in Trad/Simp Chinese.

Change 381896 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Language switch between Chinese variants

https://gerrit.wikimedia.org/r/381896

Change 381896 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Language switch between Chinese variants

https://gerrit.wikimedia.org/r/381896

This is fixed on Nexus 5 (6.0.1), Wikipedia v2.6.203-alpha-2017-10-11.

ABorbaWMF subscribed.

Tested on Nexus 4 with Android 5.1.1 and Pixel with Android 8.0.0 on Alpha App 2.6.203-alpha-2017-10-11

This one looks good. I am seeing both variants.