The latest versions of jsdom require Node.js v6 or newer. (Versions of jsdom below v10 still work with Node.js v4, but are unsupported.)
We are using ^10.1.0
Specifically it uses destructuring assignment (const { URL } = ...) which throws an exception in Node < 6 (see http://http://node.green/)
Ideally our Node version requirements should match the rest of the services team (Parsoid/RESTBase).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update Node.js dependency | mediawiki/services/cxserver | master | +1 -1 |
We follow the guidance from service team for this. In T170548: nodejs 6.11 the services team rolled out 6.11 as WMF production version.
Ideally our Node version requirements should match the rest of the services team (Parsoid/RESTBase).
Specifically for cxserver, using WMF production version as baseline is more important and useful IMO.
Change 379701 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[mediawiki/services/cxserver@master] Update Node.js dependency
Sure, whatever the services team is happy with (@ssastry, @GWicke?). Also https://www.mediawiki.org/wiki/Content_translation/cxserver/Setup should be updated.
Parsoid works with v4 but production is v6 like all other services. node v4 is being EOL-ed April 2018 according to https://github.com/nodejs/Release ... so making v6 the minimum supported version seems reasonable since it is not that far away before being default anyway. For Parsoid, we'll drop official v4 support around the time it EOLs.
Change 379701 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Update Node.js dependency