Page MenuHomePhabricator
Create Task
Maniphest T176237

ContentTranslation on Hebrew Wiki crashes on Chrome for a page with multiple templates
Closed, ResolvedPublic
Actions

Description

This comes from Facebook and Hebrew Wiki. A user is complaining that ContentTranslation has crashed and they can't edit anymore.

Details from the user:

Console error:

(anonymous) @ VM4235:328

VM4235:339 This page is using the deprecated ResourceLoader module "jquery.ui.widget".

(anonymous) @ VM4235:339

VM4235:389 This page is using the deprecated ResourceLoader module "jquery.tipsy".

mw.loader.implement.css @ VM4235:389

VM4235:323 This page is using the deprecated ResourceLoader module "jquery.ui.core".

Please use "mediawiki.ui.button" or "oojs-ui" instead.

mw.loader.implement.css @ VM4235:323

VM4248:91 Uncaught TypeError: Cannot read property 'prop' of undefined

    at TemplateTool.replaceTargetTemplate (eval at <anonymous> (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4:681</nowiki>), <anonymous>:91:147)

    at TemplateTool.markUndaptable (eval at <anonymous> (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4:681</nowiki>), <anonymous>:92:864)

    at Object.eval (eval at <anonymous> (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4:681</nowiki>), <anonymous>:94:498)

    at Object.<anonymous> (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:47:129</nowiki>)

    at fire (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45:122</nowiki>)

    at Object.fireWith [as rejectWith] (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46:431</nowiki>)

    at Object.<anonymous> (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:47:322</nowiki>)

    at fire (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45:122</nowiki>)

    at Object.fireWith [as rejectWith] (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46:431</nowiki>)

    at Object.deferred.(anonymous function) (<nowiki>https://he.wikipedia.org/w/load.php?debug=false&lang=he&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:47:790</nowiki>)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+9 -2Prevent js error in template adaptation
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Sep 19 2017, 5:29 PM
Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptSep 19 2017, 5:29 PM
KartikMistry added a subscriber: KartikMistry.Sep 21 2017, 11:14 AM
Arrbee assigned this task to santhosh.Oct 27 2017, 6:07 AM
Arrbee triaged this task as Medium priority.
Arrbee raised the priority of this task from Medium to Needs Triage.
Arrbee triaged this task as Medium priority.
Arrbee added a project: Language-2017-Oct-Dec.
Arrbee moved this task from Needs Triage to Oct-Dec 2017 on the ContentTranslation board.
Framawiki added a subscriber: Framawiki.Nov 8 2017, 7:17 PM
• Halibutt added a subscriber: • Halibutt.Nov 25 2017, 12:14 AM

Did T179997 fix this as well? @Framawiki ?

Framawiki added a comment.Nov 25 2017, 8:14 PM

euh, I'm not a ContentTranslation developer (but I spam them with my reports). As far I can see both error logs are different, so it's difficult to know.

santhosh added a comment.Nov 27 2017, 9:35 AM

My attempts to reproduce this is failed. I tried the translation of en:The Phantom Tollbooth to he and ca languages using Chrome and Firefox. If any of you were able to reproduce, please give the langauge pair title details. Also the template if any caused the issue.

Meanwhile I will try to do some defence against the js error shown above from happening.

gerritbot added a subscriber: gerritbot.Nov 27 2017, 9:52 AM

Change 393556 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Prevent js error in template adaptation

https://gerrit.wikimedia.org/r/393556

gerritbot added a project: Patch-For-Review.Nov 27 2017, 9:52 AM
gerritbot added a comment.Nov 27 2017, 1:11 PM

Change 393556 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Prevent js error in template adaptation

https://gerrit.wikimedia.org/r/393556

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 27 2017, 2:00 PM
Nikerabbit moved this task from Backlog to QA on the Language-2017-Oct-Dec board.Nov 27 2017, 4:11 PM
Nikerabbit removed a project: Patch-For-Review.
Etonkovidova added a subscriber: Etonkovidova.Nov 30 2017, 1:17 AM

Checked in hewiki (wmf.10) - there are still plenty of [CX] Error in adapting template. missing data-mw that seem to be triggered on nested templates, e.g.

{{quote box | align = right | width = 25em | salign = right
| quote =  "Oh dear, all those words again," thought Milo as he climbed into the wagon with Tock and the cabinet members. "How are you going to make it move? It doesn't have a—"<br>
"Be very quiet," advised the duke, "for it goes without saying."<br>
And, sure enough, as soon as they were all quite still, it began to move through the streets, and in a very short time they arrived at the royal palace.
| source = ''The Phantom Tollbooth'' (in Dictionopolis) {{sfn|Juster and Marcus|p=79}}}}

But ContentTranslation does not crash (I did not try to publish it though).

Etonkovidova added a comment.Nov 30 2017, 6:47 PM

As for the scope of the issue,

ContentTranslation has crashed and they can't edit anymore

the issue is resolved. "Error in adapting template..." is a know error and will be addressed in different phab tasks.

Etonkovidova closed this task as Resolved.Nov 30 2017, 6:48 PM
Nikerabbit moved this task from QA to Done on the Language-2017-Oct-Dec board.Dec 1 2017, 8:30 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL