FlaggedRevs' checkbox label is displayed weirdly in VisualEditor save dialog.
Description
Description
Details
Details
Customize query in gerrit
Event Timeline
Comment Actions
This is a regression from https://gerrit.wikimedia.org/r/#/c/375020/, as pointed out on the change by @Catrope:
FIXME this causes errors/notices. label-message can either be a string (message key) or a Message object. FlaggedRevs uses the latter, setting the label-message of one of its checkboxes to $this->msg( 'revreview-check-flag-p' )->numParams( $this->article->getPendingRevCount() );
Running something that's either a message key or a Message object through $this->msg() works just fine, but using it as an array index breaks: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2017.09.14/mediawiki?id=AV6CDuKFePsvZ6LqgLXw&_g=h@44136fa . Even if it did automagically __toString() the Message object, that would have the wrong outcome, because we appear to want the message key as the index here, not the rendered message.
This FR checkbox is the only checkbox that uses a Message object, and I fear it might be completely broken by this change. But maybe magic __toString()-ification of the Message object both on this line and in the JSONification of $checkboxesDef makes it work by accident?
Comment Actions
Actually, I'm not sure if this is UBN-worthy? As far as I can tell the checkbox works correctly, it's just a minor display issue. I've got a patch for this ready anyway, it's just a decision of whether to backport/deploy it. @Deskana?
Comment Actions
Change 378985 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Backporting and deploying makes sense. Although it's not "Unbreak Now!", it's still a glitch that'd be nice to have fixed fast.
Comment Actions
Change 378985 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Change 378990 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Change 378991 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.19] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Change 378990 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.18] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Change 378991 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.30.0-wmf.19] ApiVisualEditor: Fix checkbox label message handling with Message objects
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-09-19T23:56:00Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.19/extensions/VisualEditor/ApiVisualEditor.php: SWAT: [[gerrit:378991|ApiVisualEditor: Fix checkbox label message handling with Message objects]] T176249 (duration: 00m 48s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2017-09-19T23:57:13Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.18/extensions/VisualEditor/ApiVisualEditor.php: SWAT: [[gerrit:378990|ApiVisualEditor: Fix checkbox label message handling with Message objects]] T176249 (duration: 00m 49s)