Page MenuHomePhabricator

[betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers
Open, Needs TriagePublic

Description

Note: The issue is not specific to monobook - the markers will not be displayed on RC with Vector skin. However, Vector skin does not use markers on RC page to provide any additional clues, unlike in monobook.

In monobook skin markers have different colors to additionally convey information about a Watched page. Discarding colored markers with 'Group by page' may deprive users of that additional info.

  1. In betalabs change the skin to monobook and go to RC page with new filters enabled.
  2. On RC page results will be displayed with markers - e.g.

  1. Enable 'Grouped results by page' option. The grouped results will be displayed without markers - e.g.

Without filters enabled, 'Grouped by page' option displays the markers:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2017, 7:24 PM
Etonkovidova renamed this task from [betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers to [betalabs] monobook RC page with filters and 'Grouped results by page' does not display markers.Sep 19 2017, 7:34 PM
Etonkovidova updated the task description. (Show Details)

OMG. Who can explain what all those monobook symbols mean, so we can work around them?

This comment was removed by Catrope.

It's pretty simple: green is unseen. Both the arrows and squares turn green if the entry is unseen.

Etonkovidova updated the task description. (Show Details)Sep 20 2017, 8:00 PM

@Pginer-WMF can you please figure out how we should best fix this monobook system? Should we just override it, for example? Or do we need to adapt it?

@Pginer-WMF can you please figure out how we should best fix this monobook system? Should we just override it, for example? Or do we need to adapt it?

It depends on how much we want to support the seen/unseen distinction and keep backwards compatibility. Here are some options depending on that:

  • Remove the additional marks. With the new filtering system, users can filter and highlight seen/unseen changes which was not possible before. We can keep their override for showing unseen elements in bold if needed (although I'm a bit confused on the use of bold since it has been considered too prominent in other cases).
  • Keep the marks in general, but remove them when they conflict with highlight. That would make the system to be backwards compatible (users will see the marks they are used to), and these will only be removed when a new feature that also relies on marks is used. However, i find it a bit strange that different skins provide different functionality beyond just changing the styling and layout.
  • Support the same kind of marks we do on the Watchlist. For the Watchlist we have a similar case of surfacing the seen/unseen information in a way that is compatible with highlighting. That's what I would recommend if we were aiming to surface the seen/unseen status in general, but given that it is a specific customisation on one skin I'm not sure it is worth moving those users through the change.
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 15 2018, 9:58 AM
Pginer-WMF removed Pginer-WMF as the assignee of this task.Mar 20 2020, 8:49 AM