Page MenuHomePhabricator
Create Task
Maniphest T176263

Certain image URL schemes are being (re)written to 'http' in production
Closed, ResolvedPublic
Actions

Description

I've noticed an odd discrepancy in service responses between local and the Beta Cluster on the one hand, and production on the other: the http: scheme is being prepended or, apparently in some cases, rewritten from https.

Two examples:

From /page/mobile-sections-lead/Barack_Obama:

Beta Cluster/Local (expected):

"image": {
  "file": "President_Barack_Obama.jpg",
  "urls": {
    "320": "//upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/320px-President_Barack_Obama.jpg",
    "640": "//upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/640px-President_Barack_Obama.jpg",
    "800": "//upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/800px-President_Barack_Obama.jpg",
    "1024": "//upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/820px-President_Barack_Obama.jpg"
  }
},

Prod (unexpected):

"image": {
  "file": "President_Barack_Obama.jpg",
  "urls": {
    "320": "http://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/320px-President_Barack_Obama.jpg",
    "640": "http://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/640px-President_Barack_Obama.jpg",
    "800": "http://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/800px-President_Barack_Obama.jpg",
    "1024": "http://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/820px-President_Barack_Obama.jpg"
  }
},

From /page/summary/Barack_Obama:

Beta Cluster/Local (expected):

"thumbnail": {
  "source": "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/256px-President_Barack_Obama.jpg",
  "width": 256,
  "height": 320,
  "original": "https://upload.wikimedia.org/wikipedia/commons/8/8d/President_Barack_Obama.jpg"
},

Prod (unexpected):

"thumbnail": {
  "source": "https://upload.wikimedia.org/wikipedia/commons/thumb/8/8d/President_Barack_Obama.jpg/256px-President_Barack_Obama.jpg",
  "width": 256,
  "height": 320, 
  "original": "http://upload.wikimedia.org/wikipedia/commons/8/8d/President_Barack_Obama.jpg"
},

Details

SubjectRepoBranchLines +/-
Rewrite lead image URLs to https and bump mobile-sections to 0.12.4mediawiki/services/mobileappsmaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.Sep 19 2017, 8:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2017, 8:41 PM
• Mholloway renamed this task from Certain image URL scheme are being (re)written to 'http' in production to Certain image URL schemes are being (re)written to 'http' in production.Sep 19 2017, 8:42 PM
• Mholloway updated the task description. (Show Details)
• Mholloway moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.
• Mholloway added a project: Mobile-Content-Service.
• Mholloway updated the task description. (Show Details)Sep 19 2017, 10:40 PM
• Mholloway updated the task description. (Show Details)
• Mholloway updated the task description. (Show Details)Sep 20 2017, 1:40 AM
• mobrovac added a project: Services (doing).Sep 20 2017, 9:12 AM
• mobrovac subscribed.

The main reason for this is that the MW API returns http origins for images. For the RESTBase side, I have created PR #865 to encompass the original field as well, which should fix the problem in the summary end point, but for mobile-sections a similar hack will need to be placed in the MCS.

gerritbot subscribed.Sep 20 2017, 2:23 PM

Change 379237 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/services/mobileapps@master] Fix: Rewrite http URLs to https in buildLeadImageUrls

https://gerrit.wikimedia.org/r/379237

gerritbot added a project: Patch-For-Review.Sep 20 2017, 2:23 PM
gerritbot added a comment.Sep 20 2017, 3:32 PM

Change 379237 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Rewrite lead image URLs to https and bump mobile-sections to 0.12.4

https://gerrit.wikimedia.org/r/379237

• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Sep 20 2017, 3:33 PM
• Mholloway moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Stashbot mentioned this in T175759: Add scowiki TFA to Explore feed.Sep 20 2017, 8:34 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-09-20T20:34:46Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@e23bf66]: Update mobileapps to d46860e (T175759 T176263)

Stashbot added a comment.Sep 20 2017, 8:40 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-20T20:40:51Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@e23bf66]: Update mobileapps to d46860e (T175759 T176263) (duration: 06m 05s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 20 2017, 8:44 PM
• mobrovac edited projects, added Services (done); removed Services (doing).Sep 21 2017, 8:10 AM

The fix for the summary end point in RB has been merged and deployed.

• Mholloway closed this task as Resolved.Sep 21 2017, 12:38 PM
• Mholloway claimed this task.

Thanks, @mobrovac!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL