Page MenuHomePhabricator
Create Task
Maniphest T176265

Block images lose captions when moved
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Looks like another TreeModifier regression, the image node is getting constructed before the children have been populated, so the CE node thinks it shouldn't render a caption.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Wait for tree to finish building before updating captionmediawiki/extensions/VisualEditormaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 19 2017, 8:58 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 19 2017, 8:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders triaged this task as Unbreak Now! priority.Sep 19 2017, 8:58 PM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptSep 19 2017, 8:58 PM
gerritbot subscribed.Sep 19 2017, 8:59 PM

Change 379053 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Wait for tree to finish building before updating caption

https://gerrit.wikimedia.org/r/379053

gerritbot added a project: Patch-For-Review.Sep 19 2017, 8:59 PM
Esanders added a comment.Sep 19 2017, 9:00 PM

The above patch fixes symptom but not the cause. Pinging @dchan

DLynch subscribed.Sep 20 2017, 3:34 PM
gerritbot added a comment.Sep 20 2017, 3:41 PM

Change 379053 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Wait for tree to finish building before updating caption

https://gerrit.wikimedia.org/r/379053

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 20 2017, 4:00 PM
greg lowered the priority of this task from Unbreak Now! to High.Sep 25 2017, 11:28 PM
greg subscribed.
In T176265#3619380, @Esanders wrote:

The above patch fixes symptom but not the cause. Pinging @dchan

Still UBN! with the symptom fix? Doesn't appear to be so, thus lowering.

Esanders merged a task: T176918: Caption stops displaying when you move an image.Sep 28 2017, 4:32 PM
Esanders merged a task: T176917: Captions not showing when you insert an image.
Esanders added a subscriber: • Whatamidoing-WMF.
• Deskana set the point value for this task to 1.Oct 17 2017, 5:16 PM
• Deskana removed a project: Patch-For-Review.
• Deskana lowered the priority of this task from High to Low.Aug 27 2018, 1:24 PM
• Deskana moved this task from To Triage to Freezer on the VisualEditor board.
matmarex closed this task as Resolved.Nov 2 2018, 1:40 PM
matmarex subscribed.

Ed's workaround was removed in rEVED26e7728272e2: ve.ce.MWBlockImageNode: Allow normal CE rendering to handle the caption. I think we can consider this properly fixed.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 2 2018, 1:40 PM
Liuxinyu970226 unsubscribed.Nov 3 2018, 12:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits