If you accidentally merge a submodule commit pointing to an unavailable SHA, then run fundraising_code_update, it barrels ahead with the cleanup phase and asks you to delete everything. It should stop and yell at you.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Bad submodule pointer commit | Ejegg | wikimedia/fundraising/dash | deployment | +1 -1 |
Event Timeline
Comment Actions
Change 397883 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/dash@deployment] Bad submodule pointer commit
Comment Actions
This should be fixed, the new behavior is that a fatal git error causes the script to exit. A bad submodule hash shows up during the preview/lint stage, and exiting at this stage prevents git changes beyond fetch.
Also the state file updates immediately after project changes, so fatal errors in one project shouldn't interfere with state tracking for other projects.