Page MenuHomePhabricator
Create Task
Maniphest T176286

Mobile font size is 0.8em for devices with screen width 320px and smaller
Closed, ResolvedPublic
Actions

Description

In last month or 2-3 weeks mobile version of russian wikipedia has become smaller (icons, labels , everything) and uncomfortable to read.
iOS 8.1 iPhone 5

Developer notes

The value of wgMFDeviceWidthMobileSmall (which is meant for feature phones) was increased from 280px to 320px resulting in this change.

Replication steps

  • Decrease your browser screen resolution to 320px
  • Verify the font size is the same as when its 720px.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Correct feature phone threshold detectionmediawiki/skins/MinervaNeuewmf/1.31.0-wmf.2+12 -10
Correct feature phone threshold detectionmediawiki/skins/MinervaNeuemaster+12 -10
Customize query in gerrit

Event Timeline

Yanpas created this task.Sep 19 2017, 11:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2017, 11:02 PM
Yanpas added a comment.Sep 19 2017, 11:03 PM

image.jpg (1×640 px, 155 KB)

Liuxinyu970226 added projects: MobileFrontend, Web-Team-Backlog-Archived.Sep 20 2017, 11:07 AM
Liuxinyu970226 added a project: Russian-Sites.
Liuxinyu970226 subscribed.Sep 20 2017, 11:13 AM

Excuse me @Yanpas I'm wondering which browser you're using? Safari? Yandex? Opera?...

• bmansurov renamed this task from Mobile site font has smaller to Mobile site font has become smaller.Sep 20 2017, 2:06 PM
• bmansurov moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.
ovasileva triaged this task as Medium priority.Sep 20 2017, 3:11 PM
ovasileva added a subscriber: • Nirzar.
Yanpas added a comment.Sep 20 2017, 7:16 PM

I'm using Safari mobile.

I would also like to admit^

  • I see the same regression on english wikipedia
  • not only fonts have become smaller, but the entire site
• Nirzar added a comment.Sep 20 2017, 7:19 PM

@Yanpas looks like you have enabled beta mode. would you mind going to settings and checking the font size settings?

we have a beta feature running that lets users change the font size.

Yanpas added a comment.Sep 20 2017, 8:04 PM

Yes, I've enabled beta recently to see the fix sooner. I've set font size 130% and it looks almost the same as it was before.

• Nirzar added a comment.Sep 20 2017, 8:13 PM

this is what im seeing on 100% and 110% on beta mode / safari / ios / ru.m

100%

IMG_5431.PNG (1×750 px, 136 KB)

110%

IMG_5432.PNG (1×750 px, 125 KB)

Jdlrobson closed this task as Invalid.Sep 27 2017, 9:33 PM
Jdlrobson subscribed.

There were some intentional icon changes in August but no changes to the font-size. As with any design change that might be taking time to get used to, but we won't be reverted back.

Feel free to reopen this if you can find some further information e.g. a patch in the commit history that could be responsible but everything looks as expected to me so there's nothing we can do without some clearer definition of the problem.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptSep 27 2017, 9:33 PM
Jdlrobson renamed this task from Mobile site font has become smaller to Mobile font size is 0.8em for devices with screen width 320px and smaller.Sep 28 2017, 2:21 PM
Jdlrobson reopened this task as Open.
Jdlrobson edited projects, added MinervaNeue; removed Russian-Sites, MobileFrontend.
Jdlrobson updated the task description. (Show Details)

Okay I got to the bottom of this.

gerritbot subscribed.Sep 28 2017, 2:24 PM

Change 381222 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Restore feature phone threshold to 280px

https://gerrit.wikimedia.org/r/381222

gerritbot added a project: Patch-For-Review.Sep 28 2017, 2:24 PM
Jdlrobson updated the task description. (Show Details)Sep 28 2017, 2:34 PM
Jdlrobson closed this task as Resolved.Sep 28 2017, 3:36 PM
Jdlrobson claimed this task.
Jdlrobson moved this task from Backlog to TODO on the MinervaNeue board.
Jdlrobson added a project: User-Jdlrobson.

Will roll out on next weeks train

Jdlrobson moved this task from Inbox to Done on the User-Jdlrobson board.Sep 28 2017, 3:37 PM
gerritbot added a comment.Oct 4 2017, 8:32 PM

Change 382238 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.31.0-wmf.2] Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/382238

gerritbot added a comment.Oct 4 2017, 9:39 PM

Change 382238 abandoned by Jdlrobson:
Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/382238

gerritbot added a comment.Oct 4 2017, 9:40 PM

Change 382238 restored by Jdlrobson:
Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/382238

gerritbot added a comment.Oct 4 2017, 9:40 PM

Change 382238 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.31.0-wmf.2] Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/382238

gerritbot added a comment.Oct 4 2017, 9:48 PM

Change 381222 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/381222

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 4 2017, 10:00 PM
gerritbot added a comment.Oct 4 2017, 11:10 PM

Change 382238 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.31.0-wmf.2] Correct feature phone threshold detection

https://gerrit.wikimedia.org/r/382238

Stashbot subscribed.Oct 4 2017, 11:18 PM

Mentioned in SAL (#wikimedia-operations) [2017-10-04T23:18:17Z] <catrope@tin> Synchronized php-1.31.0-wmf.2/skins/MinervaNeue/: Correct feature phone threshold detection (T176286) (duration: 00m 53s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 5 2017, 12:01 AM
MBinder_WMF moved this task from Needs Prioritization to 2017-18 Q1 on the Web-Team-Backlog-Archived board.Mar 6 2018, 6:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits