Page MenuHomePhabricator

'Latest revision' hides all Flow actions
Closed, ResolvedPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jmatazzoni renamed this task from Lastest filters + Logged actions filters don't display Topics edits pages on Watchlist to 'Latest revision' + 'Logged actions' filters don't display Topics edits pages on Watchlist.Sep 20 2017, 10:26 PM

@Stryn and @Trizek, is the title here wrong? It talks about Watchlist. But the examples are from Recent Changes.

@Stryn and @Trizek, playing with the functions on Mediawiki, it appears that the title was wrong in various ways:

  1. It's not that 'Latest revision' + 'Logged actions' is incompatible with topics, it's that
    • 'Latest revision' conflicts with topics and
    • 'Logged actions' conflicts with topics
  2. Also, I suspect this is true of both Watchlist and Recent changes.

Are both of those points right? I have updated the title on that understanding. Let me know if the new title is wrong.

jmatazzoni renamed this task from 'Latest revision' + 'Logged actions' filters don't display Topics edits pages on Watchlist to 'Latest revision' and 'Logged actions' filters both conflict with the Topics namespace.Sep 20 2017, 10:57 PM

I think it's:

  • 'Latest revision' conflicts with Flow actions (in theory it does not, in practice it should for now). Per @SBisson, we might not want to handle this as an actual conflict.
  • 'Latest revision' conflicts with 'Logged actions' (this doesn't have anything to do with the original report, but we discussed it and it seems like a true conflict)

I think above is what we discussed earlier today.

In principle, there is no reason for 'Logged actions' to conflict with Topic namespace (in practice, there might not be any such log entries, but I don't think it's something we should hard-code).

  • 'Latest revision' conflicts with 'Logged actions' (this doesn't have anything to do with the original report, but we discussed it and it seems like a true conflict)

Per @Etonkovidova, this is not really a conflict, since there are exceptions for some logged actions that are linked a revision (like move)

Mattflaschen-WMF renamed this task from 'Latest revision' and 'Logged actions' filters both conflict with the Topics namespace to 'Latest revision' hides all Flow actions.Sep 21 2017, 6:04 PM

Checked after https://gerrit.wikimedia.org/r/#/c/379614/ (along with T176328: 'Latest revision' + 'Logged actions' filters don't display Deleted pages on Watchlist and Recent Changes )

Checked Flow board actions - new topic, edit posts, reply, summary, edit board description, and other actions: delete, hide, re-open, resolve. All Flow page actions are fetched by 'Latest revision'.

QA Recommendation: Resolve