Page MenuHomePhabricator

Improve New Filters performance by changing DB query based on highlights?
Open, Needs TriagePublic

Description

To discuss:

In some cases, providing the highlight classes requires an extra join. So we may want to only do that join on demand.

This would require (sometimes - this could be annotated, so the frontend knew when it needed to reload) reloading the results when highlights change, which is a cost of its own.

See T176228: Special:RelatedChanges with edit filters has query error due to missing join on page table

Event Timeline

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 21 2017, 3:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jmatazzoni renamed this task from Change DB query based on highlights? to Improve New Filters performance by changing DB query based on highlights?.Oct 3 2017, 5:36 PM

let's consider this and see if we think it would make much difference. @Catrope, what do you think?

Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 15 2018, 9:58 AM