Page MenuHomePhabricator
Create Task
Maniphest T176393

TwoColConflict is overriding EditPage for all ContentFormats
Closed, ResolvedPublic
Actions

Description

The TwoColConflict extension is overriding EditPage for all ContentModel. So, it is overriding the custom EditPage subclasses used by some ContentModels like the "Page" and "Index" one of ProofreadPage, making them not possible to edit.

The "AlternateEdit" hook handler should be modified in order to don't do anything on contents that are not Wikitext.

Examples of affected pages when the TwoColConflict beta feature is enabled:

Details

Related Gerrit Patches:
mediawiki/core : masterEditPage: Extract some edit conflict code into EditConflictHelper
mediawiki/extensions/TwoColConflict : masterRefactor to extend TextConflictHelper instead of EditPage

Related Objects

Event Timeline

Tpt created this task.Sep 21 2017, 8:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2017, 8:10 AM
Tpt triaged this task as High priority.Sep 21 2017, 8:10 AM
Tpt added a comment.Sep 21 2017, 8:24 AM

I do not manage to reproduce this issue with the 1.30mwf19 version of MediaWiki core and ProofreadPage. The root cause is maybe an other extension that also overrides this action for all content models or something related to the WM environment (content model lookup?).

Billinghurst added a subscriber: Billinghurst.Sep 21 2017, 8:31 AM

not sure what I am meant to be seeing, or not seeing. All works as expected for me.

Tpt renamed this task from "edit" and "submit" overrided actions are not used anymore for the Index and Page content models to TwoColConflict is overriding EditPage for all ContentFormats.Sep 21 2017, 12:57 PM
Tpt edited projects, added Two-Column-Edit-Conflict-Merge; removed MediaWiki-ContentHandler.
Tpt updated the task description. (Show Details)
Restricted Application added a project: TCB-Team. · View Herald TranscriptSep 21 2017, 12:57 PM
Tpt added a comment.Sep 21 2017, 12:59 PM

User:einstein95 have found the root cause of this issue: it's because TwoColConflict and ProofreadPage does competitive overriding of EditPage. I have updated the task description accordingly.

Slowking4 added a subscriber: Slowking4.EditedSep 21 2017, 1:28 PM

i could save edits with index. fields did not load
additionally, in page space, header and footer field did not appear, but "noinclude" wikicode was shown, buttons to edit page status did not appear, but "pagestatus" wikicode did

Ankry added a subscriber: Ankry.Sep 21 2017, 1:35 PM
Legoktm added a subscriber: Legoktm.Sep 21 2017, 2:44 PM

See my comment on T175260#3597752. I suppose we need to fix this sooner rather than later :)

gerritbot added a subscriber: gerritbot.Sep 22 2017, 11:52 AM

Change 379724 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] EditPage: Extract some edit conflict code into EditConflictHelper

https://gerrit.wikimedia.org/r/379724

gerritbot added a project: Patch-For-Review.Sep 22 2017, 11:52 AM

Change 379725 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TwoColConflict@master] Refactor to extend TextConflictHelper instead of EditPage

https://gerrit.wikimedia.org/r/379725

Legoktm claimed this task.Sep 22 2017, 7:59 PM
Legoktm added projects: MediaWiki-Page-editing, MediaWiki-Platform-Team.
Legoktm moved this task from Inbox to Future on the MediaWiki-Platform-Team board.
Bonvol added a subscriber: Bonvol.Sep 23 2017, 7:43 PM

Reproduction scenario (this is how I encountered this bug):

  1. On Wikisource account enable in Preferences -> Beta Features a feature called Two Column Edit Confilct View
  2. Pick a random page in Page namespace to edit
  3. Proofread status is shown within edit text (<pagequality...). Buttons specifying page status do not appear. Screenshot available here: http://www.imgpaste.net/image/e3IK6. That makes any proofreading cumbersome.
WMDE-Fisch claimed this task.Oct 30 2017, 12:09 PM
WMDE-Fisch moved this task from Watching/Blocked/External to Todo on the WMDE-QWERTY-Team board.
gerritbot added a comment.Oct 31 2017, 8:09 PM

Change 379724 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Extract some edit conflict code into EditConflictHelper

https://gerrit.wikimedia.org/r/379724

gerritbot added a comment.Oct 31 2017, 8:09 PM

Change 379725 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Refactor to extend TextConflictHelper instead of EditPage

https://gerrit.wikimedia.org/r/379725

Tobi_WMDE_SW closed this task as Resolved.Nov 1 2017, 7:48 AM
Tobi_WMDE_SW moved this task from Todo to Done on the WMDE-QWERTY-Team board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL