Page MenuHomePhabricator

Show the legal text on the "new translation" dialog only in the final step
Closed, ResolvedPublic

Description

The dialog to select an article to translate (T111094) includes a legal text ("By clicking the 'Start translation' button...") for users to confirm the licensing terms of their contribution. This legal text should be shown only at the confirmation step (after the article has been selected).

Currently the legal text is shown too early:

This represents unnecessary distraction for the user at that point and may create confusion since it makes reference to a button that is not visible. In the initial step all the grey area with the text should be hidden instead and only become visible when an article has been selected.

Event Timeline

Pginer-WMF updated the task description. (Show Details)

Change 379786 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Change New translation embedded dialog behavior

https://gerrit.wikimedia.org/r/379786

Change 379786 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Change New translation embedded dialog behavior

https://gerrit.wikimedia.org/r/379786

Etonkovidova added a subscriber: Etonkovidova.EditedSep 27 2017, 10:40 PM

Checked in cx-testing and cawiki (1.31.0-wmf.1). The legal test is displayed only after the selection of an article is made.

First step - click on 'New translation' - the legal text is not displayed.

Some article is selected - the legal text is displayed.

Etonkovidova closed this task as Resolved.Sep 27 2017, 10:41 PM