Page MenuHomePhabricator

#jump-to-nav top margin is too big
Closed, ResolvedPublic


The top margin of #jump-to-nav is too big since MediaWiki 1.30/wmf.19.

Take a look at the amount of whitespace between firstHeading and mw-content-text here.

I'm guessing it's something to do with this change.

Event Timeline

It's not the top-margin the issue, as it is 0 most of the time, but the bottom margin, that also should be 0 when these links are not displayed.
So I guess this due to another change.

This as also be reported on village pump.

Hmm, this is not right...
The margin-top of #jump-to-nav was compensating for it's margin-bottom and now is no longer doing that...

BTW. since when does #jump-to-nav require javascript to function ? (as in, do we still need JS for that ?)

Change 384129 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] Fix margin of #jump-to-nav

matmarex assigned this task to TheDJ.
matmarex removed a project: Patch-For-Review.

Change 384129 merged by jenkins-bot:
[mediawiki/core@master] Fix margin of #jump-to-nav

Change 396331 had a related patch set uploaded (by Kghbln; owner: TheDJ):
[mediawiki/core@REL1_30] Fix margin of #jump-to-nav

Change 396331 abandoned by Kghbln:
Fix margin of #jump-to-nav

I have tried to author a revert