Page MenuHomePhabricator

VisualEditor IME test failing in CI on pull-through, but not locally or in the source repo?
Closed, ResolvedPublic8 Story Points

Description

The "Setup slugs in TreeModifier" patch in VE-core passed unit tests locally and in CI, and was merged. However, the pull-through into VE-MW is failing mediawiki-extensions-qunit-jessie in one of the fake IME tests that's also tested in VE-core.

https://gerrit.wikimedia.org/r/#/c/379557/ and also https://gerrit.wikimedia.org/r/#/c/379421/ for just this patch alone.

Local testing shows this passing in Chrome and Chromium 58, 60, and 61, so it might be a CI config issue?

This currently blocks development (and deployment of an important fix). :-(

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2017, 12:28 AM

Change 379781 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[VisualEditor/VisualEditor@master] IME tests: Temporarily disable 'backspace-chromium-ubuntu-none.js'

https://gerrit.wikimedia.org/r/379781

Change 379781 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] IME tests: Temporarily disable 'backspace-chromium-ubuntu-none.js'

https://gerrit.wikimedia.org/r/379781

Change 379557 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7d38cf7ee)

https://gerrit.wikimedia.org/r/379557

OK, it's actually failing all IME tests; this was just the first one. Commenting it out just made the next fail, and the next…

dchan added a comment.Sep 25 2017, 3:23 AM

As I've noted in gerrit, the Filibuster dump at patchset https://gerrit.wikimedia.org/r/#/c/379557/21/ on the CI system differs from the one I get on my local machine. At the very start of the first IME test, when "गा" is inserted, the CI system has

<p class='ve-ce-branchNode ve-ce-contentBranchNode ve-ce-paragraphNode'><span class='ve-ce-branchNode-slug ve-ce-branchNode-inlineSlug'><#text>गा</#text><img class='ve-ce-chimera ve-ce-chimera-webkit'></img></span></p>

whereas my local machine has

<p class='ve-ce-branchNode ve-ce-contentBranchNode ve-ce-paragraphNode'><#text>गा</#text><span class='ve-ce-branchNode-slug ve-ce-branchNode-inlineSlug'><img class='ve-ce-chimera ve-ce-chimera-webkit'></img></span></p>

I.e. the CI system has [text],[inlineSlug] whereas my local machine has [inlineSlug],[text].

Perhaps this looks like some browser- or environment-specific difference in how the DOM functions work, when called from ve.ce.TestRunner#changeText .

dchan added a comment.Sep 25 2017, 9:14 AM

OK, I have tested a rewritten version of ve.ce.TestRunner#changeText on the CI environment with Filibuster ( https://gerrit.wikimedia.org/r/#/c/379557/23/ ), and it looks like it works. So now we just need to put it into VE standalone then pull that through into VE-MW. And then see whether I'm completely wrong or not :)

Change 380451 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Make IME tests more consistent across test environments

https://gerrit.wikimedia.org/r/380451

dchan claimed this task.Sep 25 2017, 9:37 AM

Change 380451 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make IME tests more consistent across test environments

https://gerrit.wikimedia.org/r/380451

Change 379557 had a related patch set uploaded (by Jforrester; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0ec5fe55f)

https://gerrit.wikimedia.org/r/379557

Jdforrester-WMF closed this task as Resolved.Sep 25 2017, 3:10 PM
Jdforrester-WMF set the point value for this task to 8.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 25 2017, 3:10 PM

Change 379557 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0ec5fe55f)

https://gerrit.wikimedia.org/r/379557

Change 380534 had a related patch set uploaded (by Jforrester; owner: Divec):
[VisualEditor/VisualEditor@REL1_30] Make IME tests more consistent across test environments

https://gerrit.wikimedia.org/r/380534

Change 380534 merged by jenkins-bot:
[VisualEditor/VisualEditor@REL1_30] Make IME tests more consistent across test environments

https://gerrit.wikimedia.org/r/380534