Page MenuHomePhabricator

Replace the Unicode arrows in wikidiff2 with a neutral symbol and add CSS classes for later styling
Closed, ResolvedPublic


From test results in T176217 with RTL languages we decided on changing the arrow symbols in the C++ library to something neutral and do the arrow like styling in a later step with CSS so that it can address the RTL layout.

  • arrows should be replaced with the ( MEDIUM BLACK CIRLCE U+26AB )
  • a tags should get classes, I suggest something like mw-diff-movedpara-rhs and mw-diff-movedpara-lhs

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2017, 2:09 PM

Change 380952 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/php/wikidiff2@master] Moved lines: Allow for styling of RTL languages

@MaxSem can you have another look at the patch? Would be great to get this merged soon, so we can finally move on rolling out the feature to production wikis.

Change 380952 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Moved lines: Allow for styling of RTL languages

Tobi_WMDE_SW moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-09-19 board.
Tobi_WMDE_SW closed this task as Resolved.Oct 17 2017, 8:48 AM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-QWERTY-Team board.Oct 17 2017, 2:24 PM