Page MenuHomePhabricator

Design Consolidation - use light/dark mode colors instead of single colors in drawable xmls
Closed, DeclinedPublic

Description

Due to API shortcomings we are using a hard coded color in custom drawable background xmls. This has forced us to use a common color for light and dark mode , at places where distinction was needed.

Eg: view_list_card_item_image_background.xml

This task will require going throught all drawables where color attributes are directly used, working with design to figure out if light/dark segregation is needed for them, and then come up with a solution to use attributes in drawable instead of solutions , while taking care of the lower API issue with attr in drawables.

Event Timeline

Dbrant subscribed.

Color attributes ?attr should not really be used directly in vector drawables. Instead, we should apply the proper tint to the drawables in the places they are used.