Page MenuHomePhabricator

Old templates can lead to sup elements inside summary
Closed, ResolvedPublic

Description

In some places references are marked up with the class .reference rather than .mw-ref when the Ref label template is used.

Given the deprecation warning there "Notice This is no longer the recommended method of citing sources. If a note list separate from the list of references is desired" this is probably intended.

However, it does lead to some weird summaries:
e.g.
http://0.0.0.0:6927/en.wikipedia.org/v1/page/summary/Charles%20Darwin
http://0.0.0.0:6927/en.wikipedia.org/v1/page/summary/Charles%20Manson

{
"type": "standard",
"revision": "801244013",
"extract": "Charles Milles Manson :136–7 is an American convicted mass murderer and former cult leader who led what became known as the Manson Family, a quasi-commune that arose in California in the late 1960s. Manson's followers committed a series of nine murders at four locations in July and August 1969. In 1971 he was found guilty of first-degree murder and conspiracy to commit murder for the deaths of seven people – most notably of the actress Sharon Tate – all of which were carried out by members of the group at his instruction. Manson also received first-degree murder convictions for two other deaths. Manson was originally sentenced to death, but his sentence was commuted to life imprisonment when California invalidated the state's death penalty statute in 1972. He is currently serving multiple life sentences at California State Prison in Corcoran.",
"extract_html": "<p><b>Charles Milles Manson</b> <sup class=\"reference nowrap\" about=\"#mwt6\" id=\"mwDQ\">:136–7</sup> is an American convicted mass murderer and former <span>cult</span> leader who led what became known as the <span>Manson Family</span>, a quasi-<span>commune</span> that arose in California in the late 1960s. Manson's followers committed a series of nine murders at four locations in July and August 1969. In 1971 he was found guilty of first-degree murder and <span class=\"mw-redirect\">conspiracy</span> to commit murder for the deaths of seven people – <span>most notably of the actress Sharon Tate</span> – all of which were carried out by members of the group at his instruction. Manson also received first-degree murder convictions for two other deaths. Manson was originally sentenced to death, but his sentence was commuted to life imprisonment when California invalidated the state's death penalty statute in 1972. He is currently serving multiple <span>life sentences</span> at <span>California State Prison</span> in <span>Corcoran</span>.</p>"
}

I suggest we strip these since it is cheap.

Related Objects

Event Timeline

Jdlrobson renamed this task from S to Old templates can lead to sup elements inside summary.
Jdlrobson updated the task description. (Show Details)

Change 379852 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Strip any .reference elements

https://gerrit.wikimedia.org/r/379852

Change 379852 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Strip any .reference elements

https://gerrit.wikimedia.org/r/379852

Mentioned in SAL (#wikimedia-operations) [2017-10-03T22:26:53Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@82aa7d6]: Update mobileapps to 5dc0c02 (T175762 T177001 T176525 T176517 T176519) (duration: 06m 14s)

Jdlrobson closed this task as Resolved.Oct 17 2017, 6:26 PM
Jdlrobson claimed this task.