Parenthetical: New edge case with nested brackets
Closed, ResolvedPublic
Actions

Description

A new edge case has been identified and a test case has been captured in WIP: Improve parenthetical handling.

There is a problem in the removeNestedParentheticals function - it does not correctly strip a parenthetical nested within other parenthetical.

This leads to invalid summaries on the following examples:

Details

	Subject	Repo	Branch	Lines +/-
	Fix removeNestedParentheticals parenthetical handling	mediawiki/services/mobileapps	master	+27 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T169242 Develop Page Content Service for Reading Clients
Resolved	None	T177425 Develop General Layer of PCS
Resolved	• Jhernandez	T177426 Develop structured JSON APIs for general consumption
Resolved	• Mholloway	T177431 Develop a Summary JSON API
Resolved	Dereckson	T68374 Enable Hovercards on se.wikimedia.org (Swedish chapter wiki)
Resolved	Jdlrobson	T70860 [GOAL] Graduate Page Previews feature (Popups extension) out of Beta Feature
Resolved	ovasileva	T154635 [EPIC] Deploy page previews to English and German Wikipedia
Resolved	ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
Resolved	Jdlrobson	T173952 Remove A/B testing instrumentation code
Duplicate	None	T167433 Switch all projects to the new (and yet to be built) summary-html endpoint for page previews
Duplicate	None	T167429 Make enwiki and dewiki fetch previews from the summary-html RESTBase endpoint
Resolved	ovasileva	T165018 Page previews can consume new summary-HTML endpoint
Declined	Jdlrobson	T111329 [GOAL] Page previews on mobileweb
Resolved	Jdlrobson	T164010 [EPIC] Strengthen the APIs we provide in reading web maintained extensions
Resolved	ovasileva	T113094 [EPIC] The Page Summary API needs to provide useful content for the majority of articles
Resolved	Jdlrobson	T176525 Parenthetical: New edge case with nested brackets

Event Timeline

Jdlrobson created this task.Sep 22 2017, 9:36 PM

Jdlrobson edited projects, added Mobile-Content-Service; removed Reading Epics (Page Previews), Epic, Tracking-Neverending, Page-Previews.

Jdlrobson removed a project: Web-Team-Backlog.

matej_suchanek unsubscribed.Sep 23 2017, 8:08 AM

A new edge case has been identified:

What's the edge case?

Jdlrobson updated the task description. (Show Details)Sep 25 2017, 12:32 PM

Jdlrobson updated the task description. (Show Details)Sep 25 2017, 7:56 PM

Jdlrobson updated the task description. (Show Details)Sep 25 2017, 8:59 PM

Change 379930 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/services/mobileapps@master] Fix removeNestedParentheticals parenthetical handling

https://gerrit.wikimedia.org/r/379930

gerritbot added a project: Patch-For-Review.Sep 25 2017, 9:00 PM

Jdlrobson added a project: User-Jdlrobson.Sep 27 2017, 8:48 PM

Jdlrobson moved this task from Inbox to Blocked on the User-Jdlrobson board.Sep 27 2017, 8:58 PM

nshahquinn-wmf unsubscribed.Oct 3 2017, 7:55 PM

Change 379930 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Fix removeNestedParentheticals parenthetical handling

https://gerrit.wikimedia.org/r/379930

Jdlrobson edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Patch-For-Review, Product-Infrastructure-Team-Backlog-Deprecated.Oct 3 2017, 9:25 PM

Jdlrobson moved this task from Blocked to Done on the User-Jdlrobson board.

Jdlrobson moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Mentioned in SAL (#wikimedia-operations) [2017-10-03T22:20:38Z] <bsitzmann@tin> Started deploy [mobileapps/deploy@82aa7d6]: Update mobileapps to 5dc0c02 (T175762 T177001 T176525 T176517 T176519)

Stashbot mentioned this in T176517: Pages that are redirects give empty summary objects.Oct 3 2017, 10:20 PM

Stashbot mentioned this in T176519: Old templates can lead to sup elements inside summary.

• Nirzar unsubscribed.Oct 3 2017, 10:24 PM

Mentioned in SAL (#wikimedia-operations) [2017-10-03T22:26:53Z] <bsitzmann@tin> Finished deploy [mobileapps/deploy@82aa7d6]: Update mobileapps to 5dc0c02 (T175762 T177001 T176525 T176517 T176519) (duration: 06m 14s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 3 2017, 11:04 PM

Jdlrobson closed this task as Resolved.Oct 10 2017, 6:53 PM

Jdlrobson claimed this task.

Parenthetical: New edge case with nested bracketsClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Parenthetical: New edge case with nested brackets
Closed, ResolvedPublic
Actions

Related Objects
Search...