Page MenuHomePhabricator
Create Task
Maniphest T176528

ErfgoedBot missing_commonscat_links crashes with NoneType
Closed, ResolvedPublic
Actions

Description

Traceback (most recent call last):
  File "/data/project/heritage/pywikibot/pwb.py", line 263, in <module>
    if not main():
  File "/data/project/heritage/pywikibot/pwb.py", line 257, in main
    run_python_file(filename, [filename] + args, argvu, file_package)
  File "/data/project/heritage/pywikibot/pwb.py", line 121, in run_python_file
    main_mod.__dict__)
  File "/data/project/heritage/erfgoedbot/missing_commonscat_links.py", line 259, in <module>
    main()
  File "/data/project/heritage/erfgoedbot/missing_commonscat_links.py", line 253, in main
    makeStatistics(mconfig, totals)
  File "/data/project/heritage/erfgoedbot/missing_commonscat_links.py", line 187, in makeStatistics
    totalCategories += totals.get((countrycode, lang))
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

Details

SubjectRepoBranchLines +/-
Restructure missing_commonscat_linkslabs/tools/heritagemaster+652 -109
Re-factor statistics bit of unused_monument_imageslabs/tools/heritagemaster+217 -123
Add first tests for missing_commonscat_linkslabs/tools/heritagemaster+47 -0
Guard against empty totals when making statisticslabs/tools/heritagemaster+4 -4
Respect `skip` config when making statslabs/tools/heritagemaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

JeanFred created this task.Sep 22 2017, 11:04 PM
JeanFred moved this task from Backlog to Bugs on the Wiki-Loves-Monuments-Database board.Sep 23 2017, 3:08 PM
gerritbot added a subscriber: gerritbot.Sep 23 2017, 3:27 PM

Change 379971 had a related patch set uploaded (by Jean-Frédéric; owner: Jean-Frédéric):
[labs/tools/heritage@master] Respect skip config when making stats in missing_commonscat_links

https://gerrit.wikimedia.org/r/379971

gerritbot added a project: Patch-For-Review.Sep 23 2017, 3:27 PM
JeanFred claimed this task.Sep 23 2017, 3:28 PM
JeanFred triaged this task as Medium priority.
JeanFred added a comment.Sep 23 2017, 3:41 PM

This also happened on unused_images:

  File "erfgoedbot/unused_monument_images.py", line 249, in <module>
    main()
  File "erfgoedbot/unused_monument_images.py", line 243, in main
    makeStatistics(mconfig, totals)
  File "erfgoedbot/unused_monument_images.py", line 177, in makeStatistics
    totalImages += totals.get((countrycode, lang))
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'
gerritbot added a comment.Sep 23 2017, 3:47 PM

Change 379974 had a related patch set uploaded (by Jean-Frédéric; owner: Jean-Frédéric):
[labs/tools/heritage@master] Guard against empty totals when making statistics

https://gerrit.wikimedia.org/r/379974

gerritbot added a comment.Sep 23 2017, 4:16 PM

Change 379971 merged by jenkins-bot:
[labs/tools/heritage@master] Respect skip config when making stats

https://gerrit.wikimedia.org/r/379971

Stashbot added a subscriber: Stashbot.Sep 23 2017, 6:25 PM

Mentioned in SAL (#wikimedia-cloud) [2017-09-23T18:25:21Z] <JeanFred> Deploy latest from Git master: 1a7b88c (T176528), 150f545 (T176530)

Stashbot mentioned this in T176530: ErfgoedBot write-to-wiki crashes when hitting AbuseFilter (PageSaveRelatedError).Sep 23 2017, 6:25 PM
gerritbot added a comment.Sep 26 2017, 8:37 AM

Change 380060 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] [WIP]Restructure missing_commonscat_links Statistics

https://gerrit.wikimedia.org/r/380060

gerritbot added a comment.Sep 26 2017, 11:55 AM

Change 379974 abandoned by Jean-Frédéric:
Guard against empty totals when making statistics

Reason:
Superseded

https://gerrit.wikimedia.org/r/379974

gerritbot added a comment.Jul 20 2018, 11:02 PM

Change 447107 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Move get_id_from_sort_key to common in preparation for re-use

https://gerrit.wikimedia.org/r/447107

gerritbot added a comment.Jul 20 2018, 11:03 PM

Change 447108 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Add first tests for missing_commonscat_links

https://gerrit.wikimedia.org/r/447108

gerritbot added a comment.Jul 20 2018, 11:43 PM

Change 447109 had a related patch set uploaded (by Lokal Profil; owner: Lokal Profil):
[labs/tools/heritage@master] Re-factor statistics bit of unused_monument_images

https://gerrit.wikimedia.org/r/447109

gerritbot added a comment.Jul 22 2018, 10:36 AM

Change 447108 merged by jenkins-bot:
[labs/tools/heritage@master] Add first tests for missing_commonscat_links

https://gerrit.wikimedia.org/r/447108

gerritbot added a comment.Jul 22 2018, 10:45 AM

Change 447109 merged by jenkins-bot:
[labs/tools/heritage@master] Re-factor statistics bit of unused_monument_images

https://gerrit.wikimedia.org/r/447109

gerritbot added a comment.Jul 22 2018, 11:27 AM

Change 380060 merged by jenkins-bot:
[labs/tools/heritage@master] Restructure missing_commonscat_links

https://gerrit.wikimedia.org/r/380060

Stashbot added a comment.Jul 22 2018, 1:12 PM

Mentioned in SAL (#wikimedia-cloud) [2018-07-22T13:12:40Z] <Lokal_Profil> Deploy latest from Git master: 6dba253, f3552bc (T176528), 0eb8a6f (T176528), 9cad025, ac7ab36 (T176528, T176722)

Stashbot added a comment.Jul 22 2018, 1:12 PM

Mentioned in SAL (#wikimedia-cloud) [2018-07-22T13:12:40Z] <Lokal_Profil> Deploy latest from Git master: 6dba253, f3552bc (T176528), 0eb8a6f (T176528), 9cad025, ac7ab36 (T176528, T176722)

Stashbot added a comment.Jul 22 2018, 1:12 PM

Mentioned in SAL (#wikimedia-cloud) [2018-07-22T13:12:40Z] <Lokal_Profil> Deploy latest from Git master: 6dba253, f3552bc (T176528), 0eb8a6f (T176528), 9cad025, ac7ab36 (T176528, T176722)

Stashbot mentioned this in T176722: Make missing_commonscat_links support sparql datasets.Jul 22 2018, 1:12 PM
Lokal_Profil added a subscriber: Lokal_Profil.Jul 25 2018, 10:48 AM

Check the logs to see if this is still happening.

Also check to ensure c:Commons:Monuments_database/Missing_commonscat_links/Statistics gets updated.

Lokal_Profil closed this task as Resolved.Aug 23 2018, 9:25 PM
Lokal_Profil claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL