Page MenuHomePhabricator

load_composer_autoloader in extension.json is not cache safe
Closed, ResolvedPublic

Description

In ExtensionProcessor::getExtraAutoloaderPaths() we do a file_exists() check to see if the composer autoloader exists and then cache the result. But if the file existence changes, the cache won't be invalidated, either causing the autoloader to never be loaded, or to be loaded when it doesn't exist - both bad things.

Event Timeline

Legoktm created this task.Sep 23 2017, 5:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2017, 5:17 AM

Change 379957 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] registration: Fix caching of load_composer_autoloader

https://gerrit.wikimedia.org/r/379957

Jdforrester-WMF closed this task as Resolved.Sep 25 2017, 3:12 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Change 379957 merged by jenkins-bot:
[mediawiki/core@master] registration: Fix caching of load_composer_autoloader

https://gerrit.wikimedia.org/r/379957