Page MenuHomePhabricator

In new filters add option to auto-expand the grouped changes
Open, Needs TriagePublic

Description

As a user who has selected rcfilters-group-results-by-page on Special:RecentChanges, I want all the grouped changes to auto-expand immediately, so that I do not have to manually click every expand-arrow.

I've historically used a global.js user-script to do this:

// Auto-Expand all grouped RC/Watchlist entries.
$( function () { $('.mw-enhancedchanges-arrow').click(); } );

as detailed in T109103: Enhanced recent changes - add a method to Auto-expand all entries, without requiring user.js changes.

I suggest making this feature an integral part of the new filters, so that more editors can benefit.

Event Timeline

Quiddity created this task.Sep 23 2017, 4:56 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 23 2017, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hi @Quiddity, please explain what the difference is between this and your other ticket on a similar theme, T109103?

Thanks. We'll have a look at these in the next Triage meeting.

IIRC, I think this task was intended to cover the new ERI system, whereas 109103 was intended to cover the classic RC and still extent watchlist system. I don't know if that would materially matter for development purposes. Essentially I want to encourage providing the same functionality in both Recent Changes and in Watchlist pages, and in both ERI and in Classic interfaces. 2 tasks to make sure neither get forgotten. :-)

JTannerWMF added a subscriber: JTannerWMF.

Ping Joe when you have a design.

Based on the description, the need seems more related to configuration (i.e., defining the preferred mode of presenting the groups) more than operation (i.e., having tools to quickly switch back and forth between the modes to achieve something).
Given that assumption, I think it makes sense to expose such option as part of the display settings.

I'd propose the following:

  • When the option to group results is selected, and only in that case, show an additional "Expand groups by default" checkbox below it to allow users to decide whether groups should appear expanded or collapsed.
  • If the "Expand groups by default" option is selected, the current groups displayed and those that may appear later will be shown expanded. If the option is unchecked, all the groups displayed and those appearing later will be shown collapsed.
  • Keep the display settings panel open after the user has changed any option. Currently it closes after any change, which taxes the users that want to do more than one change and hides the feedback of the change (which may affect the discoverability of the option in this case).

The mockups below show the interacton:

@jmatazzoni, any thoughts?

Thanks @Pginer-WMF, this looks good to me. My one thought is that the "Expand groups by default" setting might be more discoverable if it were present but grayed out until the user selects "Group results by page." Once the latter is selected, the former would become available.

As I say, my interest here is discoverability. There may well be some users who have experience with the system, for example, who don't select Group Results because they don't like expanding the groups individually. By exposing the option (grayed), we announce that it is available to them.

+1 to Joe's thought about making it more discoverable for people who've been unhappy with the existing collapsed-default. and +1 to Pau's understanding of the problem (i.e. that as a user of this feature, I don't ever need to turn it off).

Thanks @Pginer-WMF, this looks good to me. My one thought is that the "Expand groups by default" setting might be more discoverable if it were present but grayed out until the user selects "Group results by page." Once the latter is selected, the former would become available.

As I say, my interest here is discoverability. There may well be some users who have experience with the system, for example, who don't select Group Results because they don't like expanding the groups individually. By exposing the option (grayed), we announce that it is available to them.

Thanks for the feedback @jmatazzoni and @Quiddity.

With the proposed approach I was trying to keep a balance by providing the tool to those that need it, but don't add more complexity to those that do not (and may not know when reading "Expand groups by default" which groups we are talking about). I created this interactive prototype to illustrate the interaction better.

Having said that, I think that showing it initially disabled is also a valid option. I'd be worried if we expected the number of options related to groups or not to grow over time. But given that its just one more item, it is not taxing those not interested in grouping results heavily. I also created a prototype to illustrate this approach.

If we want to favour the anticipation of possibilities we can go with the later one. I added also the updated version of the mockups n case it needs to be copied somewhere else:

jmatazzoni added a comment.EditedJun 21 2018, 5:00 PM

I like this solution. Thanks Pau!

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 10:57 PM
Catrope added a project: patch-welcome.
Catrope added a subscriber: Catrope.

This is a good idea, but since it was a low priority for the Collaboration team, the Growth team won't be able to prioritize it.

Quiddity updated the task description. (Show Details)Dec 1 2018, 7:39 AM
Pginer-WMF removed Pginer-WMF as the assignee of this task.Mar 20 2020, 8:49 AM
Pginer-WMF added a subscriber: Pginer-WMF.