Saved snaks have wikibase-snakview- class
Closed, ResolvedPublic
Actions

Description

Looks like this happens when the template is initialized with unknown hash (empty string), and we never remove it.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+1 -1	Remove wikibase-snakview- class when updating hash

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Resolved	Lucas_Werkmeister_WMDE	T168532 Check constraints on qualifiers and references
Resolved	Lucas_Werkmeister_WMDE	T171725 Add snak hashes to entity HTML output
Resolved	Lucas_Werkmeister_WMDE	T176633 Saved snaks have wikibase-snakview- class

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 25 2017, 1:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2017, 1:52 PM

Lucas_Werkmeister_WMDE added a parent task: T171725: Add snak hashes to entity HTML output.Sep 25 2017, 1:52 PM

Lucas_Werkmeister_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.

Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.

Change 380510 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove wikibase-snakview- class when updating hash

https://gerrit.wikimedia.org/r/380510

gerritbot added a project: Patch-For-Review.Sep 25 2017, 1:54 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Sep 25 2017, 1:54 PM

Change 380510 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove wikibase-snakview- class when updating hash

https://gerrit.wikimedia.org/r/380510

Lucas_Werkmeister_WMDE closed this task as Resolved.Sep 26 2017, 8:52 AM

Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.