Page MenuHomePhabricator
Create Task
Maniphest T176646

Image inspector obscures caption
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

image.png (369×405 px, 110 KB)

Now that captions are directly editable, this is an annoyance as you have to de-focus the image, and in environments where it is less convenient to de-focus the image, (e.g. ContentTranslation) it's a real issue.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Set bounding element to full frame for MW imagesmediawiki/extensions/VisualEditormaster+2 -1
Update VE core submodule to master (723b85d6c)mediawiki/extensions/VisualEditormaster+1 -1
Allow focusable nodes to define an element to be their bounding boxVisualEditor/VisualEditormaster+11 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 25 2017, 3:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2017, 3:47 PM
gerritbot subscribed.Sep 25 2017, 4:00 PM

Change 380538 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Allow focusable nodes to define an element to be their bounding box

https://gerrit.wikimedia.org/r/380538

gerritbot added a project: Patch-For-Review.Sep 25 2017, 4:00 PM

Change 380539 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Set bounding element to full frame for MW images

https://gerrit.wikimedia.org/r/380539

Esanders added a comment.Sep 25 2017, 4:02 PM

After patch:

image.png (432×426 px, 92 KB)

gerritbot added a comment.Sep 25 2017, 5:09 PM

Change 380538 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Allow focusable nodes to define an element to be their bounding box

https://gerrit.wikimedia.org/r/380538

gerritbot added a comment.Sep 25 2017, 5:17 PM

Change 380555 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (723b85d6c)

https://gerrit.wikimedia.org/r/380555

Jdforrester-WMF closed this task as Resolved.Sep 25 2017, 5:18 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 25 2017, 5:18 PM
gerritbot added a comment.Sep 25 2017, 5:27 PM

Change 380555 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (723b85d6c)

https://gerrit.wikimedia.org/r/380555

gerritbot added a comment.Sep 25 2017, 5:29 PM

Change 380539 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Set bounding element to full frame for MW images

https://gerrit.wikimedia.org/r/380539

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 25 2017, 6:00 PM
Ryasmeen reopened this task as Open.Sep 28 2017, 4:56 PM
Ryasmeen subscribed.

hmm, I still see the context menu obscuring the caption on Beta and test2
Is it really part of wmf.1 release?

Screen Shot 2017-09-28 at 9.54.51 AM.png (550×1 px, 235 KB)

Jdforrester-WMF closed this task as Resolved.Sep 28 2017, 6:36 PM
Jdforrester-WMF edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).
Jdforrester-WMF subscribed.

Fixed now in master. Whoops.

Ryasmeen added a project: Verified.Sep 28 2017, 9:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits