Page MenuHomePhabricator

Switch services checks to a protected page
Closed, ResolvedPublic

Description

We have the checker script checking certain endpoints on our services. Most of the endpoints use a real wiki page on a real wiki, for summary it's Barack_Obama for example. Sometimes these pages are vandalized which creates alerts in production while in reality the service works correctly. We need to switch all of the checks to some page with more protection, or create a special testing page in the User namespace, protect it and point all of the checks to it.

See also: https://wikitech.wikimedia.org/wiki/Incident_documentation/20170922-REST-API-alert-pageimage-update

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It would be nice to create the page in a way that it challenges as many RESTBase/Parsoid/MCS features as possible. @ssastry @bearND do you have some sandbox pages which you already use to test Parsoid/MCS so that we could copy-paste them to this new protected testing page?

@Pchelolo I've created a Frankenstein page for that. It consists of various body parts of other pages, hence the name. ;)

@Pchelolo I've created a Frankenstein page for that. It consists of various body parts of other pages, hence the name. ;)

Well done! :-)

That's a great page @bearND the only issue with that is PageImages are not activated on user pages, so we can't test summaries that use the PageImages extension.

We need to somehow get this page into the main namespace and explain the purpose of this page to the community and get someone to protect the page. I personally don't have the protect rights on wiki, do you know anyone who does?

@Pchelolo I could move it to testwiki but then the templates wouldn't work, and all the links became red. Then it wouldn't be the same test.

I personally don't have the protect rights on wiki, do you know anyone who does?

I think @Deskana might. But I think that still wouldn't justify creating a page on enwiki main namespace for purely testing our services. We could maybe use a combination of the two: one on enwiki user namespace for the templates and link checking, and another one on testwiki main namespace for pageimages and everything else?

I think @Deskana might. But I think that still wouldn't justify creating a page on enwiki main namespace for purely testing our services. We could maybe use a combination of the two: one on enwiki for the templates and link checking, and another one on testwiki for pageimages and everything else?

That sounds like a good plane, we only need page images for the summary endpoint, so it might work. I'll prepare a patch for RESTBase

I think @Deskana might. But I think that still wouldn't justify creating a page on enwiki main namespace for purely testing our services. We could maybe use a combination of the two: one on enwiki user namespace for the templates and link checking, and another one on testwiki main namespace for pageimages and everything else?

I protected your test page on enwiki. Is there anything else I can help with? :-)

Thank you @Deskana!

I've created a PR to switch monitoring tests to the protected pages: https://github.com/wikimedia/restbase/pull/883

The summary test points to the test wiki, because we need to have PageImages working for that test.

Merged. To be deployed Tuesday. Resolving. Thanks all for help!