On search overlay the search button and close button should be inset to fit within the safe area
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Sep 26 2017, 6:41 PM

Description

Search on iPhone X landscape	Example of correct inset on the News app

Currently the search button and close button on the search overlay are extended beyond the safe area causing them to be very close to the rounded corner of the screen. These icons should be moved into the safe area, which will require making the search box shorter.

Related Objects
Search...

Status	Assigned	Task
Resolved	• JMinor	T176775 iPhone X useability and design issues for iOS app
Resolved	JoeWalsh	T176778 On search overlay the search button and close button should be inset to fit within the safe area
Resolved	JoeWalsh	T176804 Search results should be extended to the safe area and the search results cell background should be full bleed

Event Timeline

cmadeo created this task.Sep 26 2017, 6:41 PM

cmadeo updated the task description. (Show Details)Sep 26 2017, 7:14 PM

cmadeo created subtask T176804: Search results should be extended to the safe area and the search results cell background should be full bleed.Sep 26 2017, 8:30 PM

JoeWalsh claimed this task.Sep 27 2017, 5:43 PM

JoeWalsh moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 28 2017, 7:37 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 29 2017, 1:27 PM

@JoeWalsh this looks really good, thanks!

Re: T176804 if it's not too hard to update it would be nice to have the search icon and search close button be aligned with the list items. If this will cause a lot of issues feel free to move this over into needs QA.