Page MenuHomePhabricator

Search results should be extended to the safe area and the search results cell background should be full bleed
Closed, ResolvedPublic

Description

IMG_0008 2.PNG (1×2 px, 285 KB)

On the search overlay in landscape the 'Recently searched' items are currently too far inset and should be extended to the safe / readability margins.
The cell background color should be extended to be full bleed with the HRs either full bleed or extending to the screen margin on the right and terminating at the safe / readable area on the left.

Event Timeline

@JoeWalsh this is looking much better!
There are still a few alignment issues which were present in the original design but are more pronounced now.

Simulator Screen Shot - iPhone X - 2017-10-02 at 13.34.40.png (1×2 px, 94 KB)

Would it be possible to:

  • Move the recently searched clear button in 1pt?
  • Move the 'More' link to be right aligned with the search close icon?
  • This would be a bigger change that would reach outside of this interface, but would it be possible to have the Search icon and search close icon align with the list items (eg. the magenta area above?)

Let me know if you'd prefer a mock-up of the changes described above.

Thanks!

Thanks for updating the alignment! Looks really nice on the iPhone X!

ABorbaWMF subscribed.

Tested on the simulator for iPhone X and it looks good.