Maniphest T176809

Vertical alignment of navigation text is off
Closed, ResolvedPublic
Actions

Assigned To

• NHarateh_WMF

Authored By

	• JMinor
	Sep 26 2017, 9:04 PM

Tags

Referenced Files

	F9880131: iPhone X - Article - Landscape.png
	Sep 28 2017, 5:47 PM

	F9834687: IMG_2865.PNG
	Sep 26 2017, 9:04 PM

Subscribers

Description

Our navigation labels seem to have a lower baseline than the standard/built-in apps. For example the midpoint of the chevron should vertically align with the midpoint of the font.

IMG_2865.PNG (750×1 px, 585 KB)

Proposed design solution

iPhone X landscape

iPhone X - Article - Landscape.png (375×812 px, 361 KB)

Zeplin: https://zpl.io/25Eoj1j

Design details
Reduce line height of 'Back' text to match text size (should be 17)
Vertically center align all elements in top bar
Move text up by 1pt for optical alignment

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• JMinor	T176775 iPhone X useability and design issues for iOS app
		Resolved		• NHarateh_WMF	T176809 Vertical alignment of navigation text is off

Event Timeline

• JMinor created this task.Sep 26 2017, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2017, 9:04 PM

• JMinor triaged this task as Low priority.Sep 26 2017, 9:20 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 27 2017, 9:44 PM

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 28 2017, 5:17 PM

cmadeo updated the task description. (Show Details)Sep 28 2017, 5:47 PM

cmadeo updated the task description. (Show Details)

cmadeo moved this task from Design Doing to Needs Acceptance Criteria on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.

TheDJ added a parent task: T176775: iPhone X useability and design issues for iOS app.Sep 29 2017, 9:54 AM

• NHarateh_WMF claimed this task.Oct 2 2017, 3:49 PM

• NHarateh_WMF moved this task from Needs Acceptance Criteria to Doing on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.

• NHarateh_WMF mentioned this in rAPIOS3f3c6419255c: Merge branch 'develop' into bug/T176809.Oct 4 2017, 5:35 PM

JoeWalsh mentioned this in rAPIOS1d68bb25c8fa: Merge branch 'bug/T176809' of github.com:wikimedia/wikipedia-ios into….Oct 4 2017, 6:06 PM

• NHarateh_WMF mentioned this in rAPIOS1f1f8c49167e: Merge branch 'develop' into bug/T176809.Oct 4 2017, 6:44 PM

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 4 2017, 6:56 PM

JoeWalsh mentioned this in rAPIOS329660be5014: Merge pull request #1849 from wikimedia/bug/T176809.Oct 4 2017, 7:09 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 4 2017, 7:31 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Oct 10 2017, 7:16 PM

Much more centered looking! Thanks! And the default arrow looks good.

Works on iPhone X on Beta 5.7.1 (1244)

• JMinor closed this task as Resolved.Oct 30 2017, 9:56 PM