Language indicator line is below the search area with large dynamic text sizes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JMinor
	Sep 26 2017, 9:34 PM

Description

Device: any (iPhone 6S and iPhone X tested)
Build: 5.7.0 (develop)
iOS: 11.0

Step to reproduce:

Enable more than one search language
Go to settings and set the dynamic text size to maximum (not accessibility sizes, just basic dynamic text)
Tap Search

Expected result: Blue "active" language indicator sits below the language name, but above the separator.
Actual result: Blue indicator sits below both the language name and the search UI's bottom separator

Event Timeline

• JMinor created this task.Sep 26 2017, 9:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 26 2017, 9:34 PM

• JMinor triaged this task as Low priority.Sep 26 2017, 9:34 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 27 2017, 9:44 PM

• JMinor moved this task from Needs Engineering Sync to Ready for Development on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 28 2017, 7:47 PM

JoeWalsh claimed this task.Sep 29 2017, 2:07 PM

JoeWalsh moved this task from Ready for Development to Doing on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.

JoeWalsh moved this task from Doing to Blocked or Waiting on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 29 2017, 5:32 PM

• JMinor edited projects, added ios-app-v5.7.1-Corgi-On-Nothing; removed iOS-app-v5.7.0-Corgi-On-A-Surfboard.Oct 5 2017, 6:52 PM

• NHarateh_WMF subscribed.Oct 5 2017, 7:03 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Engineering Sync on the ios-app-v5.7.1-Corgi-On-Nothing board.Oct 10 2017, 4:35 PM

• NHarateh_WMF claimed this task.Oct 10 2017, 5:50 PM

• NHarateh_WMF moved this task from Needs Engineering Sync to Doing on the ios-app-v5.7.1-Corgi-On-Nothing board.

• NHarateh_WMF added a subscriber: JoeWalsh.

The issue described in the ticket is fixed:

Simulator Screen Shot - iPhone X - 2017-10-10 at 18.34.27.png (2×1 px, 91 KB)

However, there is a different problem with increasing the font size. As the font size increases, the buttons get squashed:

Simulator Screen Shot - iPhone X - 2017-10-10 at 18.40.44.png (2×1 px, 93 KB)

Simulator Screen Shot - iPhone X - 2017-10-10 at 18.40.57.png (2×1 px, 94 KB)

One solution would be to put them in scroll view and let the user scroll horizontally:

Simulator Screen Shot - iPhone X - 2017-10-10 at 18.34.43.png (2×1 px, 94 KB)

Simulator Screen Shot - iPhone X - 2017-10-10 at 18.34.47.png (2×1 px, 94 KB)

@cmadeo what's your preference? Scroll view, hiding labels as text increases or something else?

• NHarateh_WMF moved this task from Doing to Blocked or Waiting on the ios-app-v5.7.1-Corgi-On-Nothing board.Oct 11 2017, 2:19 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Oct 30 2017, 10:31 PM

• JMinor edited projects, added iOS-app-v5.7.4-Dachshund-On-An-Elk; removed ios-app-v5.7.1-Corgi-On-Nothing.Oct 31 2017, 5:19 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Blocked or Waiting on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Oct 31 2017, 5:35 PM

• NHarateh_WMF added a subscriber: cmadeo.Nov 1 2017, 2:27 PM

• JMinor moved this task from Blocked or Waiting to Needs Design on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 13 2017, 7:20 PM

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 15 2017, 4:42 PM

@NHarateh_WMF

I like the slider approach, could we use a subtle transparency gradient to show that the languages are sliding 'behind' the More option and opposite side of the screen?


Zeplin: https://zpl.io/2EddYgg	Zeplin: https://zpl.io/2p00Zvo

cmadeo moved this task from Design Doing to Needs Acceptance Criteria on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 15 2017, 10:06 PM

• NHarateh_WMF moved this task from Needs Acceptance Criteria to Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 16 2017, 4:39 PM

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 17 2017, 12:09 AM

• NHarateh_WMF moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 2:16 PM

• NHarateh_WMF moved this task from Needs Testing Criteria to Waiting for Build on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 2:21 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 27 2017, 8:08 PM

@NHarateh_WMF This looks really good!
A bit nit picky, but is there a way to move the slide indicator below the language selection indicator?

• NHarateh_WMF moved this task from Blocked or Waiting to Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 5 2017, 7:15 PM

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 6 2017, 6:58 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 6 2017, 9:44 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 12 2017, 7:18 PM

Looks great, thanks @NHarateh_WMF!

Testing on iPhone 6 Plus (iOS 11.1.2) - Wikipedia app 5.7.3 (1281). I'll just include the screencap from my testing.

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 13 2017, 8:43 PM

ABorbaWMF subscribed.

This comment was removed by ABorbaWMF.

ABorbaWMF moved this task from Ready for PM Signoff to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 13 2017, 8:57 PM

I am also having some trouble with this one. I do not see significantly larger text at all after switching text size on the search page (Testing on iPhone 7+ and the iPad Pro).

Only 3 languages displayed

Article text is large

Slider is at max

More than 3 languages

Ipad too

@ABorbaWMF the text size only responds to the iOS system-wide setting (Settings > Display And Brightness > Text Size). Also, only showing 3 languages (even if the user has more) is how it has worked in the past and is expected behavior for now.

• NHarateh_WMF moved this task from Blocked or Waiting to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Jan 4 2018, 2:55 PM

• JMinor closed this task as Resolved.Jan 8 2018, 10:17 PM

	F11814219: IMG_1708.PNG
	Dec 13 2017, 9:07 PM

	F11814222: IMG_1710.jpg
	Dec 13 2017, 9:07 PM

	F11814362: IMG_0035.PNG
	Dec 13 2017, 9:07 PM

	F11814218: IMG_1711.PNG
	Dec 13 2017, 9:07 PM

Language indicator line is below the search area with large dynamic text sizesClosed, ResolvedPublicActions

Description

Event Timeline

Language indicator line is below the search area with large dynamic text sizes
Closed, ResolvedPublic
Actions