App.php on line 70
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Kizule
	Sep 27 2017, 4:50 AM

Description

I wanted to see global contributions of my bot on link: https://tools.wmflabs.org/guc/?user=ZoranBot

Then I got this:

Details

	Subject	Repo	Branch	Lines +/-
	Fix problem with listing of contributions	labs/tools/guc	master	+1 -1
	Fix undefined variable clusterNr	labs/tools/guc	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T176823: guc giving an error

Event Timeline

Kizule created this task.Sep 27 2017, 4:50 AM

Restricted Application added subscribers: Dvorapa, Aklapper. · View Herald TranscriptSep 27 2017, 4:50 AM

Kizule merged a task: T176823: guc giving an error.Sep 27 2017, 6:34 AM

Kizule edited projects, added Tool-Global-user-contributions; removed Tools.

Kizule added a subscriber: Akoopal.

This was probably caused by commit 4436724a57176e4111550f186e297006ec924320 several hours ago.
Replacing

if (!$clusterNr) {

with

if (!$cluster) {

in line 70 of src/App.php might fix the issue, but I can't test this.

Change 380919 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[labs/tools/guc@master] Fix problem with listing of contributions

https://gerrit.wikimedia.org/r/380919

gerritbot added a project: Patch-For-Review.Sep 27 2017, 7:03 AM

In T176831#3638540, @CorrectHorseBatteryStaple wrote:
This was probably caused by commit 4436724a57176e4111550f186e297006ec924320 several hours ago.
Replacing
if (!$clusterNr) {
with
if (!$cluster) {
in line 70 of src/App.php might fix the issue, but I can't test this.

Thank you @CorrectHorseBatteryStaple I created a patch on gerrit and maybe it will resolve a problem.

Aklapper mentioned this in T176823: guc giving an error.Sep 27 2017, 11:12 AM

Kizule triaged this task as High priority.Sep 27 2017, 1:18 PM

Change 381020 had a related patch set uploaded (by Krinkle; owner: CorrectHorseBatteryStapleWiki):
[labs/tools/guc@master] Fix undefined variable clusterNr

https://gerrit.wikimedia.org/r/381020

Change 381020 merged by jenkins-bot:
[labs/tools/guc@master] Fix undefined variable clusterNr

https://gerrit.wikimedia.org/r/381020

Thanks!

Change 380919 abandoned by Zoranzoki21:
Fix problem with listing of contributions

Reason:
Fixed with 381020

https://gerrit.wikimedia.org/r/380919

All is ok now.. I abandoned my patch, because is resolved.

Dvorapa unsubscribed.Sep 27 2017, 7:02 PM

Krinkle removed a project: Patch-For-Review.Nov 8 2017, 8:54 AM

Notice: Undefined variable: clusterNr in /mnt/nfs/labstore-secondary-tools-project/guc/labs-tools-guc/src/App.php on line 70Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Notice: Undefined variable: clusterNr in /mnt/nfs/labstore-secondary-tools-project/guc/labs-tools-guc/src/App.php on line 70
Closed, ResolvedPublic
Actions