Page MenuHomePhabricator
Create Task
Maniphest T176857

Watchlist links with "&days=0" give an incorrect display
Closed, ResolvedPublic
Actions

Description

Change rMWb747307a2002: WLFilters: Live update and View newest caused bookmarked watchlist links with a "days=0" URL parameter to interpret that as meaning 0 days rather than "all available days" as it previously did. That's an annoying breaking change, but easy enough to work around.

What caused me to waste a half hour this morning was the fact that rMWb747307a2002: WLFilters: Live update and View newest did not update SpecialWatchlist.php lines 611-615 to match, so the screen still says "Below are the last 0 changes in the last 720 hours, as of 27 September 2017, 11:48" despite it actually covering 0 hours.

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.31.0-wmf.1+1 -6Fix watchlist "in the last X hours" display
mediawiki/coremaster+1 -6Fix watchlist "in the last X hours" display
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Sep 27 2017, 11:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2017, 11:57 AM
gerritbot added a subscriber: gerritbot.Sep 27 2017, 12:04 PM

Change 380953 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Fix watchlist "in the last X hours" display

https://gerrit.wikimedia.org/r/380953

gerritbot added a project: Patch-For-Review.Sep 27 2017, 12:04 PM
gerritbot added a comment.Sep 27 2017, 1:20 PM

Change 380953 merged by jenkins-bot:
[mediawiki/core@master] Fix watchlist "in the last X hours" display

https://gerrit.wikimedia.org/r/380953

gerritbot added a comment.Sep 27 2017, 1:28 PM

Change 380968 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@wmf/1.31.0-wmf.1] Fix watchlist "in the last X hours" display

https://gerrit.wikimedia.org/r/380968

Anomie closed this task as Resolved.Sep 27 2017, 1:35 PM
Anomie claimed this task.

Fixed, and being backported to 1.31.0-wmf.1.

gerritbot added a comment.Sep 27 2017, 1:39 PM

Change 380968 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.1] Fix watchlist "in the last X hours" display

https://gerrit.wikimedia.org/r/380968

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 27 2017, 2:00 PM
Reedy mentioned this in T176033: Watchlist param days=30 doesn't override user preference 'watchlistdays' = 0.Nov 19 2017, 9:29 AM
Quiddity mentioned this in T199049: Value of 0 for "Days to show in watchlist" or "Maximum number of changes to show in watchlist" setting breaks watchlists; should instead be interpreted as maximum or no limit.Jul 8 2018, 8:07 PM
Thryduulf added a subscriber: Thryduulf.Jul 11 2018, 9:50 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 11 2018, 9:50 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL