Page MenuHomePhabricator
Create Task
Maniphest T176882

null passed to getRevisionEditor() on itwiki
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Logstash is capturing the following errors:

https://logstash.wikimedia.org/app/kibana#/dashboard/Reading-Web?_g=h@8b5b71a&_a=h@8a2a19b
[WctE6ApAMFwAAClamisAAAHV] /wiki/Discussioni_utente:FrancescoMissarino   ErrorException from line 749 of /srv/mediawiki/php-1.30.0-wmf.19/skins/MinervaNeue/includes/skins/SkinMinerva.php: PHP Error: Argument 1 passed to SkinMinerva::getRevisionEditor() must be an instance of Revision, null given
https://logstash.wikimedia.org/app/kibana#/dashboard/Reading-Web?_g=h@8b5b71a&_a=h@8a2a19b
Catchable fatal error: Argument 1 passed to SkinMinerva::getRevisionEditor() must be an instance of Revision, null given in /srv/mediawiki/php-1.30.0-wmf.19/skins/MinervaNeue/includes/skins/SkinMinerva.php on line 749

Developer Notes

Revision::newFromTitle can @return Revision|null

Details

ProjectBranchLines +/-Subject
mediawiki/skins/MinervaNeuewmf/1.30.0-wmf.19+6 -1Revision::newFromTitle may return null
mediawiki/skins/MinervaNeuewmf/1.31.0-wmf.1+6 -1Revision::newFromTitle may return null
mediawiki/skins/MinervaNeuemaster+6 -1Revision::newFromTitle may return null
Customize query in gerrit

Event Timeline

• Niedzielski created this task.Sep 27 2017, 2:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2017, 2:58 PM
Jdlrobson added a subscriber: Jdlrobson.Sep 27 2017, 3:00 PM

Did you see this in logstash or locally? If logstash can you add the URL?

• Niedzielski renamed this task from null passed to getRevisionEditor() to null passed to getRevisionEditor() on itwiki.Sep 27 2017, 3:01 PM
• Niedzielski updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Sep 27 2017, 3:01 PM
• Niedzielski added a comment.Sep 27 2017, 3:01 PM

Sorry Jon, I was using the quick task dialog and accidentally submitted it before completing the report.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Sep 27 2017, 4:36 PM
Jdlrobson triaged this task as High priority.Sep 27 2017, 6:00 PM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Sep 27 2017, 7:46 PM
Jdlrobson added a project: Wikimedia-production-error.
gerritbot added a subscriber: gerritbot.Sep 27 2017, 7:47 PM

Change 381071 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381071

gerritbot added a project: Patch-For-Review.Sep 27 2017, 7:47 PM
Jdlrobson added a project: good first task.Sep 27 2017, 7:47 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptSep 27 2017, 7:47 PM
pmiazga added a subscriber: pmiazga.Sep 27 2017, 8:11 PM

The code looks good, merged. @Jdlrobson do you want to bring it into the kanban board for visibility?

gerritbot added a comment.Sep 27 2017, 8:14 PM

Change 381071 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381071

Jdlrobson edited projects, added Readers-Web-Kanbanana-Board-Old; removed Patch-For-Review.Sep 27 2017, 8:15 PM

Sure. Moving for sign off. Guess I'll put this in blocked until we can verify with the other patch that both logstash errors are resolved?

Jdlrobson moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Sep 27 2017, 8:15 PM
Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.
pmiazga added a comment.Sep 27 2017, 8:17 PM

Yup, that's a great idea.

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Sep 27 2017, 8:30 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 27 2017, 9:00 PM
gerritbot added a comment.Sep 28 2017, 5:19 PM

Change 381258 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.30.0-wmf.19] Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381258

gerritbot added a project: Patch-For-Review.Sep 28 2017, 5:19 PM

Change 381258 abandoned by Jdlrobson:
Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381258

gerritbot added a comment.Sep 28 2017, 5:20 PM

Change 381259 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.31.0-wmf.1] Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381259

pmiazga added a comment.Sep 28 2017, 5:31 PM

I'll swat deploy it today. URL to test: https://it.m.wikipedia.org/wiki/Discussioni_utente:FrancescoMissarino

gerritbot added a comment.Sep 28 2017, 6:40 PM

Change 381259 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.31.0-wmf.1] Revision::newFromTitle may return null

https://gerrit.wikimedia.org/r/381259

gerritbot added a comment.Sep 28 2017, 6:50 PM

Change 381258 restored by Pmiazga:
Revision::newFromTitle may return null

Reason:
itwiki is still on wmf.19

https://gerrit.wikimedia.org/r/381258

gerritbot added a comment.Sep 28 2017, 6:53 PM

Change 381258 abandoned by Pmiazga:
Revision::newFromTitle may return null

Reason:
we decided to wait for wmf.1.30.1 get live verywhere instead of pushing old wmf.19 which will become obsolete today

https://gerrit.wikimedia.org/r/381258

Stashbot added a subscriber: Stashbot.Sep 28 2017, 6:54 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-28T18:54:44Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.1/skins/MinervaNeue/includes/skins/SkinMinerva.php: SWAT: [[gerrit:381259|Revision::newFromTitle may return null]] T176882 (duration: 00m 50s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)); removed MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 28 2017, 7:00 PM
pmiazga claimed this task.Sep 28 2017, 7:01 PM

The change was SWATted but to fully test it we need 1.31.1 to be deployed to group2.

pmiazga added a comment.Sep 28 2017, 8:03 PM

Tested on IT wiki - works as expected.

pmiazga closed this task as Resolved.Sep 28 2017, 8:03 PM
pmiazga removed a project: Patch-For-Review.
pmiazga moved this task from Blocked on Others to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL