URL
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cooltey
	Sep 27 2017, 8:53 PM

Description

Steps to produce

Click on this link: https://zh.wikipedia.org/wiki/核武器 in your device, it supposes to ask you to or directly open the Wikipedia App
Click on this link with non /wiki/ path article: https://zh.wikipedia.org/zh-hk/核武器 , it opens web browser.

Expected

non /wiki/ path should also be included in deep link settings. (especially for "zh.wikipedia" ), and ask you to or directly open the Wikipedia App

Actual

open web browser without ask

Links for test

Have no idea why Phabricator does not support Deep Link.
Please check links here: https://etherpad.wikimedia.org/p/DeepLinkForTests

Details

	Subject	Repo	Branch	Lines +/-
	Fix: Deep link feature for non /wiki/ URL	apps/android/wikipedia	master	+35 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	cooltey	T176909 [BUG] Deep link feature is not functional with non /wiki/ URL
		Resolved		cooltey	T137039 Enter app from website got wrong language

Event Timeline

cooltey created this task.Sep 27 2017, 8:53 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptSep 27 2017, 8:53 PM

Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript

cooltey added a subtask: T137039: Enter app from website got wrong language.Sep 27 2017, 8:53 PM

cooltey claimed this task.Sep 27 2017, 11:23 PM

cooltey updated the task description. (Show Details)Sep 27 2017, 11:57 PM

Liuxinyu970226 subscribed.Sep 28 2017, 1:11 AM

cooltey renamed this task from [BUG] Deep link feature does not handle non /wiki/ URL to [BUG] Deep link feature is not functional with non /wiki/ URL.Sep 28 2017, 5:45 PM

Change 381297 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Deep link feature for non /wiki/ URL

https://gerrit.wikimedia.org/r/381297

gerritbot added a project: Patch-For-Review.Sep 28 2017, 7:43 PM

cooltey edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada); removed Wikipedia-Android-App-Backlog.Sep 28 2017, 7:54 PM

cooltey moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.

Change 381297 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Deep link feature for non /wiki/ URL

https://gerrit.wikimedia.org/r/381297

cooltey moved this task from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 5 2017, 7:22 PM

Tested on Nexus 4 with Android 5.1.1 and Pixel with Android 8.0.0 on Alpha App 2.6.203-alpha-2017-10-11

This one is fixed. Both URLs are deep linking.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 23 2017, 1:50 PM

Dbrant closed this task as Resolved.Oct 23 2017, 1:52 PM

Liuxinyu970226 moved this task from Backlog to Closed on the Chinese-Sites board.Oct 24 2017, 4:05 AM

Liuxinyu970226 unsubscribed.Oct 25 2017, 6:28 AM

cooltey closed subtask T137039: Enter app from website got wrong language as Resolved.Oct 30 2017, 9:29 PM

Stang unsubscribed.Nov 14 2021, 12:04 AM

Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptNov 14 2021, 12:04 AM

[BUG] Deep link feature is not functional with non /wiki/ URLClosed, ResolvedPublicBUG REPORTActions