Page MenuHomePhabricator
Create Task
Maniphest T176913

adyen cookie error after entering information on mobile Safari
Closed, ResolvedPublic
Actions

Assigned To
mepps
Authored By
DStrine
Sep 27 2017, 9:29 PM
Tags
Subscribers
Aklapper
DStrine
Ejegg
gerritbot
jrobell
MBeat33
MeganHernandez_WMF
View All 11 Subscribers

Description

steps:

Result:
iframe loaded very slowly compared to other parts of the page. After filling out form and hitting the "pay" button the form in the iframe disappears and you are stuck on the form.

Expected result:
my payment completes and I go to the TY page.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DonationInterfacemaster+4 -2Filter for ios and safari
mediawiki/extensions/DonationInterfacemaster+11 -4Adyen transitional code - revert a day after deployment
mediawiki/extensions/DonationInterfacemaster+1 -4Fix exception signature
mediawiki/extensions/DonationInterfacemaster+6 -1Adyen: deal with non-iframe return
mediawiki/extensions/DonationInterfacemaster+71 -9Unit tests for Adyen multi-skin switching
mediawiki/extensions/DonationInterfacemaster+85 -25Redirect for Safari + multiskins
Customize query in gerrit

Related Objects

Event Timeline

DStrine created this task.Sep 27 2017, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2017, 9:29 PM
MBeat33 added a subscriber: MBeat33.Sep 27 2017, 10:07 PM
DStrine added a comment.Sep 27 2017, 10:09 PM

update

I didn't realize I was also getting this error:

"Unfortunately we were unable to process this request. Perhaps your browser does not accept cookies or the previous page was a saved or cached copy?"

I went and found that my cookie settings were for "allow from websites I visit". I set it to "always allow" and I was able to make a cc donation.

Pcoombe added a subscriber: Pcoombe.Sep 28 2017, 12:30 PM

Ah yes, I get the same error, and doing the same thing fixed it. Also on desktop Safari, which has the same settings.

I found this info about the setting on Apple's site https://support.apple.com/kb/PH21447?locale=en_US

Allow from websites I visit: Safari accepts cookies and website data only from websites you visit. Safari uses your existing cookies to determine whether you have visited a website before. Selecting this option helps prevent websites that have embedded content in other websites you browse from storing cookies and data on your Mac.

That would certainly impact the iframe. Afaik I've never changed this on my iPad, so this might be the default behaviour which is concerning.

Is this something we can ask Adyen to help us with?

Pcoombe renamed this task from adyen cc form disappears after entering information on ipad to adyen cookie error after entering information on Safari .Sep 28 2017, 12:44 PM
XenoRyet triaged this task as High priority.Oct 2 2017, 7:47 PM
XenoRyet added a project: Fundraising Sprint Synchronized Screaming.
XenoRyet moved this task from Triage to Current Sprint and Completed in Q1 2017-18 on the Fundraising-Backlog board.Oct 2 2017, 7:49 PM
XenoRyet added a project: Unplanned-Sprint-Work.Oct 2 2017, 8:01 PM
Ejegg added a subscriber: Ejegg.Oct 2 2017, 9:58 PM

One possibility: we do client-side browser detection and then for Safari do full redirects rather than show an iframe.

DStrine added a project: Fundraising Sprint turtles that are robotic that destroy the whole world with their foot.Oct 10 2017, 8:30 PM
DStrine added subscribers: Ppena, MeganHernandez_WMF, jrobell.Oct 16 2017, 4:06 PM

@Ppena @MeganHernandez_WMF @Pcoombe @jrobell what do you think of Elliott's suggestion? I say let's go for it at least to test.

Pcoombe added a comment.Oct 16 2017, 7:23 PM

Testing that sounds good to me.

mepps claimed this task.Oct 16 2017, 8:29 PM
mepps added a subscriber: mepps.

I'll be looking at this tonight and tomorrow morning.

gerritbot added a subscriber: gerritbot.Oct 19 2017, 8:57 PM

Change 385253 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Redirect for Safari multiskins

https://gerrit.wikimedia.org/r/385253

gerritbot added a project: Patch-For-Review.Oct 19 2017, 8:57 PM
Ejegg merged a task: T140109: Adyen form error message: cookies/cache.Oct 20 2017, 5:21 PM
Ejegg added a subscriber: Zppix.
DStrine moved this task from Current Sprint and Completed in Q1 2017-18 to Completed in Q2 2017-18 on the Fundraising-Backlog board.Oct 20 2017, 5:41 PM
mepps moved this task from Backlog to Review on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.Oct 23 2017, 7:40 PM
gerritbot added a comment.Oct 23 2017, 8:28 PM

Change 385253 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Redirect for Safari multiskins

https://gerrit.wikimedia.org/r/385253

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 23 2017, 9:00 PM
gerritbot added a comment.Oct 24 2017, 5:52 PM

Change 385483 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Unit tests for Adyen multi-skin switching

https://gerrit.wikimedia.org/r/385483

gerritbot added a comment.Oct 24 2017, 6:24 PM

Change 385483 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Unit tests for Adyen multi-skin switching

https://gerrit.wikimedia.org/r/385483

mepps moved this task from Review to Pending Deployment on the Fundraising Sprint turtles that are robotic that destroy the whole world with their foot board.Oct 24 2017, 8:00 PM
DStrine added a project: Fundraising Sprint Uptight Piano.Oct 24 2017, 8:21 PM
mepps moved this task from Backlog to Pending Deployment on the Fundraising Sprint Uptight Piano board.Oct 25 2017, 2:05 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 30 2017, 3:01 PM
gerritbot added a comment.Oct 31 2017, 9:36 PM

Change 387717 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Adyen: deal with non-iframe return

https://gerrit.wikimedia.org/r/387717

gerritbot added a comment.Oct 31 2017, 9:40 PM

Change 387727 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Fix exception signature

https://gerrit.wikimedia.org/r/387727

gerritbot added a comment.Oct 31 2017, 10:25 PM

Change 387740 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Adyen transitional code - revert a day after deployment

https://gerrit.wikimedia.org/r/387740

gerritbot added a comment.Nov 1 2017, 1:49 PM

Change 387717 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Adyen: deal with non-iframe return

https://gerrit.wikimedia.org/r/387717

gerritbot added a comment.Nov 1 2017, 1:59 PM

Change 387727 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Fix exception signature

https://gerrit.wikimedia.org/r/387727

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)); removed MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)).Nov 1 2017, 2:00 PM
gerritbot added a comment.Nov 1 2017, 4:49 PM

Change 387740 abandoned by Ejegg:
Adyen transitional code - revert a day after deployment

Reason:
To be replaced with setGatewayDefaults

https://gerrit.wikimedia.org/r/387740

DStrine added a project: Fundraising Sprint Vaporwerewolf.Nov 7 2017, 5:40 PM
mepps moved this task from Pending Deployment to Done on the Fundraising Sprint Uptight Piano board.Nov 13 2017, 3:17 PM
mepps moved this task from Backlog to Done on the Fundraising Sprint Vaporwerewolf board.
DStrine renamed this task from adyen cookie error after entering information on Safari to adyen cookie error after entering information on mobile Safari .Nov 20 2017, 5:21 PM
DStrine updated the task description. (Show Details)
mepps added a comment.Nov 20 2017, 9:32 PM

@DStrine to be clear, what browsers exactly does this affect? Just ios, only safari on ios, or andriod as well? The fix we deploye d originally was only for safari desktop.

DStrine added a comment.Nov 20 2017, 9:56 PM

chrome and firefox on android are fine. Chrome on my ipad is also fine. Firefox on my ipad shows the same bug as safari above.

gerritbot added a comment.Nov 21 2017, 4:07 PM

Change 392665 had a related patch set uploaded (by Mepps; owner: Mepps):
[mediawiki/extensions/DonationInterface@master] Filter for ios and safari

https://gerrit.wikimedia.org/r/392665

gerritbot added a comment.Nov 21 2017, 8:21 PM

Change 392665 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Filter for ios and safari

https://gerrit.wikimedia.org/r/392665

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)); removed MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 21 2017, 9:00 PM
DStrine added a project: Fundraising Sprint Winter Wanderland.Nov 21 2017, 9:38 PM
mepps added a comment.Nov 27 2017, 3:52 PM

@DStrine, this is deployed--can you confirm it fixes the issue for you?

DStrine added a comment.Nov 27 2017, 4:04 PM

I just retested. I was sent to a second page to input my CC information. It looks like it went through and I was sent to the thank you page.

Thanks for working on this!

DStrine added a comment.Nov 27 2017, 4:07 PM

@Ppena try this out on any ios device. Make sure you have cleared all history for safari and set these two settings :

"Prevent cross-site tracking" set to: ON
"Block All Cookies" set to: OFF

Ejegg moved this task from Backlog to Done on the Fundraising Sprint Winter Wanderland board.Nov 28 2017, 6:29 PM
DStrine moved this task from Completed in Q2 2017-18 to Completed in Q3 2017-18 on the Fundraising-Backlog board.Jan 2 2018, 6:12 PM
DStrine added a project: Fundraising Sprint Asymmetrical Earth Theory.Jan 2 2018, 9:19 PM
mepps added a comment.Jan 5 2018, 3:53 PM

@DStrine @Ppena Can we call this Resolved?

mepps moved this task from Backlog to Review on the Fundraising Sprint Asymmetrical Earth Theory board.Jan 5 2018, 3:53 PM
Ejegg mentioned this in T184289: Skope: Ingenico Connect: if we need 3rd-party cookies in their iframe, implement same thing as we have with Adyen.Jan 5 2018, 5:30 PM
DStrine closed this task as Resolved.Jan 5 2018, 7:53 PM

We think this looks good. I'm resolving this and we'll run a test soon.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL