Page MenuHomePhabricator
Create Task
Maniphest T176914

Wire statistics into test model included with our Vagrant role.
Closed, ResolvedPublic
Actions

Description

This testing model deterministically scores using the last two digits of revision ID, and currently can't respond with new-style statistics, so won't work for RC filters development. Simulate statistics and include in this model.

Details

SubjectRepoBranchLines +/-
Use calculated thresholdsmediawiki/vagrantmaster+8 -14
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Sep 27 2017, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2017, 9:45 PM
Halfak subscribed.Oct 9 2017, 9:12 PM

The model_info access pattern should work just fine in ORES master.

Or do you mean that we should simulate threshold statistics and store them in the revid model?

Halfak triaged this task as Low priority.Oct 9 2017, 9:12 PM
Halfak added a project: ORES.
Halfak moved this task from Unsorted to New development on the Machine-Learning-Team board.
awight added a project: good first task.Nov 1 2017, 5:16 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 1 2017, 5:16 PM
awight added a comment.Nov 9 2017, 8:38 PM
In T176914#3670697, @Halfak wrote:

Or do you mean that we should simulate threshold statistics and store them in the revid model?

That. It's constraining to not be able to test any of the thresholdy things under vagrant.

awight moved this task from New development to Active Tasks on the Machine-Learning-Team board.Nov 9 2017, 8:39 PM
awight edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.
awight mentioned this in rOREScff401e9c959: [WIP] Add statistics to the RevIdScorer.Nov 9 2017, 10:02 PM
awight added a comment.Nov 9 2017, 11:21 PM

https://github.com/wiki-ai/ores/pull/232

awight mentioned this in rORESf08ab7ebb288: Add statistics to the RevIdScorer.Nov 9 2017, 11:21 PM
awight mentioned this in rORESbae98fc11f95: Write a basic test for RevIdScorer stats.
awight added a project: Patch-For-Review.Nov 9 2017, 11:22 PM

While I'm being greedy, I'd like to take the dummy thresholds out of mw-vagrant and pull thresholds from the service.

awight claimed this task.Nov 9 2017, 11:23 PM
awight added a comment.Nov 14 2017, 3:52 PM

The ores patch is ready to go: https://github.com/wiki-ai/ores/pull/232

I'll try to integrate mw-vagrant now.

gerritbot subscribed.Nov 15 2017, 4:40 PM

Change 391578 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/vagrant@master] Use calculated thresholds

https://gerrit.wikimedia.org/r/391578

awight moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Nov 15 2017, 4:40 PM
gerritbot added a comment.Nov 15 2017, 5:28 PM

Change 391578 merged by jenkins-bot:
[mediawiki/vagrant@master] Use calculated thresholds

https://gerrit.wikimedia.org/r/391578

Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Nov 20 2017, 5:50 PM
awight closed this task as Resolved.Dec 1 2017, 8:23 PM
awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL