Page MenuHomePhabricator
Create Task
Maniphest T177028

[1.31.0-wmf.1] minor- Browser back button makes highlight-only filters do not display their highlight status in Filter menu
Closed, ResolvedPublic
Actions

Description

  1. On RC page select any filter as a highlight-only. Clicking on the filter capsule will display the highlighted status of the filter in the Filter search area.

Screen Shot 2017-09-28 at 2.24.02 PM.png (470×863 px, 104 KB)

  1. Navigate to a different page. Then, click the browser back button. The filter (and highlighting) selected in #1 will be displayed on RC page.
  2. Click on the highlight-only filter capsule - the filter menu will open but the highlight status will not be displayed.

Screen Shot 2017-09-28 at 2.49.16 PM.png (509×717 px, 92 KB)

Note: so far I could not find the other cases when the highlight status is not preserved in the Filter menu area, so that's make the issue a minor issue.

Details

SubjectRepoBranchLines +/-
RCFilters: Init highlight button based on model statemediawiki/coremaster+9 -6
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 28 2017, 9:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2017, 9:50 PM
gerritbot subscribed.Oct 3 2017, 3:35 PM

Change 382009 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCFilters: Init highlight button based on model state

https://gerrit.wikimedia.org/r/382009

gerritbot added a project: Patch-For-Review.Oct 3 2017, 3:35 PM
SBisson claimed this task.Oct 3 2017, 3:48 PM
SBisson edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
SBisson moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Oct 3 2017, 10:09 PM

Change 382009 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Init highlight button based on model state

https://gerrit.wikimedia.org/r/382009

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 3 2017, 11:00 PM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Oct 4 2017, 10:50 AM
Etonkovidova added a comment.Oct 4 2017, 6:06 PM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Oct 4 2017, 6:06 PM
SBisson merged a task: T177845: Highlight is not visible when you share a URL including some highlights.Oct 10 2017, 4:31 PM
SBisson added subscribers: Trizek-WMF, jberkel.
Etonkovidova added a comment.EditedOct 11 2017, 6:35 PM

Re-checked in 1.31.0-wmf.3 - all tests cases below behave as expected.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL