Page MenuHomePhabricator
Create Task
Maniphest T177038

Introduce ShellCommandFactory
Closed, ResolvedPublic
Actions

Description

Placeholder to mark https://gerrit.wikimedia.org/r/#/c/376874/ as a release blocker

Details

SubjectRepoBranchLines +/-
Introduce Shell\CommandFactorymediawiki/coreREL1_30+138 -19
Introduce Shell\CommandFactorymediawiki/coremaster+138 -19
Customize query in gerrit

Event Timeline

Legoktm created this task.Sep 29 2017, 5:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2017, 5:23 AM
Legoktm closed this task as Declined.Oct 4 2017, 4:57 PM

ShellCommandFactory was dropped, but the patch was merged and backported to 1.30.

Tgr added a comment.Oct 7 2017, 12:41 AM

So what is the long-term plan here? MediaWiki\Shell is in violation of our architectural guidelines now (calls to MWServices from a static utility method).

Krinkle reopened this task as Open.Oct 7 2017, 12:48 AM
Krinkle assigned this task to Legoktm.
Krinkle subscribed.
gerritbot subscribed.Oct 8 2017, 1:25 AM

Change 382919 had a related patch set uploaded (by Legoktm; owner: MaxSem):
[mediawiki/core@master] Introduce ShellCommandFactory

https://gerrit.wikimedia.org/r/382919

gerritbot added a project: Patch-For-Review.Oct 8 2017, 1:25 AM
Legoktm reassigned this task from Legoktm to MaxSem.Oct 8 2017, 1:25 AM
gerritbot added a comment.Oct 18 2017, 2:15 AM

Change 382919 merged by jenkins-bot:
[mediawiki/core@master] Introduce Shell\CommandFactory

https://gerrit.wikimedia.org/r/382919

MaxSem closed this task as Resolved.Oct 18 2017, 2:58 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 18 2017, 3:00 AM
gerritbot added a comment.Oct 18 2017, 3:15 AM

Change 384919 had a related patch set uploaded (by Legoktm; owner: MaxSem):
[mediawiki/core@REL1_30] Introduce Shell\CommandFactory

https://gerrit.wikimedia.org/r/384919

gerritbot added a comment.Oct 18 2017, 4:03 AM

Change 384919 merged by jenkins-bot:
[mediawiki/core@REL1_30] Introduce Shell\CommandFactory

https://gerrit.wikimedia.org/r/384919

ReleaseTaggerBot added a project: MW-1.30-release-notes.Oct 18 2017, 5:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL