Page MenuHomePhabricator

After triggering edit conflict in VE, error about missing Unicode support is shown
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Edit in VE, trigger an edit conflict.
  2. Decide to resolve it.

Expected:
The old editor shows up with your changes.

Actual:
The old editor shows up, but tells you your browser doesn't support Unicode.

Seems like that the fields for the new check (T67297: Remove $wgBrowserBlackList and associated EditPage methods) are not sent after switching from VE.

Event Timeline

Schnark created this task.Sep 29 2017, 7:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2017, 7:18 AM
Schnark updated the task description. (Show Details)Sep 29 2017, 9:17 AM

The code is in ve.init.mw.ArticleTarget.prototype.submit. We have to add wpUnicodeCheck: 'ℳ𝒲♥𝓊𝓃𝒾𝒸ℴ𝒹ℯ' there.

As a side note, I just discovered that Sublime Text 2 doesn't like astral plane characters, like those in our Unicode support check. It takes two backspaces to delete each and the undo stack gets messed up from doing it. Time to upgrade to ST3 I guess.

Change 381783 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission

https://gerrit.wikimedia.org/r/381783

Jdforrester-WMF closed this task as Resolved.Oct 2 2017, 5:33 PM
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 2 2017, 5:33 PM

Change 381783 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission

https://gerrit.wikimedia.org/r/381783

Change 381817 had a related patch set uploaded (by Legoktm; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@REL1_30] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission

https://gerrit.wikimedia.org/r/381817

Change 381817 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@REL1_30] ve.init.mw.ArticleTarget: Add 'wpUnicodeCheck' field to wikitext form submission

https://gerrit.wikimedia.org/r/381817