Page MenuHomePhabricator
Create Task
Maniphest T177065

PageNotificationsOptionWidget has no padding
Closed, ResolvedPublic
Actions

Description

I think default padding for option widgets was removed upstream:

image.png (215×329 px, 10 KB)

(0 padding to the left of 'English')

Details

SubjectRepoBranchLines +/-
Add left padding to PageNotificationsOptionWidgetmediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Sep 29 2017, 12:37 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 29 2017, 12:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter), good first task; removed Collaboration-Team-Triage.Nov 21 2017, 12:34 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptNov 21 2017, 12:34 AM
• jmatazzoni moved this task from Untriaged to Snack Box on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Nov 21 2017, 12:34 AM
gerritbot subscribed.Nov 28 2017, 3:06 PM

Change 393775 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/Echo@master] Add left padding to PageNotificationsOptionWidget

https://gerrit.wikimedia.org/r/393775

gerritbot added a project: Patch-For-Review.Nov 28 2017, 3:06 PM
• Petar.petkovic claimed this task.Nov 28 2017, 3:07 PM
• Petar.petkovic moved this task from Snack Box to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Nov 29 2017, 7:10 PM
gerritbot added a comment.Nov 29 2017, 7:21 PM

Change 393775 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add left padding to PageNotificationsOptionWidget

https://gerrit.wikimedia.org/r/393775

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Nov 29 2017, 8:01 PM
Etonkovidova subscribed.Nov 29 2017, 8:41 PM

Fixed in betalabs:

Screen Shot 2017-11-29 at 12.40.10 PM.png (187×321 px, 21 KB)

Etonkovidova closed this task as Resolved.Nov 29 2017, 8:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL